Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove criteria F #1658

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove criteria F #1658

wants to merge 2 commits into from

Conversation

twof
Copy link
Contributor

@twof twof commented Feb 17, 2025

Criteria F is a duplicate of Criteria C and is overly vague

@benjie
Copy link
Member

benjie commented Feb 17, 2025

F is not a duplicate of C, which is demonstrated by the evaluations for them differing - both proposal 2 and 4 fail criteria C (clarified in #1659), but for F proposal 2 is consistent because in a new schema with @strictNullability, Int always means "semantically non-nullable". Proposal 4 fails criteria F because it has two modes of operation on the same schema, and Int means essentially opposite things in these two modes: either nullable or non-nullable depending on the mode. Perhaps rather than removing this you can help reword it to make the difference clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants