-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix navbar links and combine sponsor/partner pages #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@YassinEldeeb is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ef09580
to
7585c4b
Compare
@YassinEldeeb @jorydotcom I think the header is way over populated |
ah, I didn’t think it’d wrap with smaller screens. Is the register button really needed in the nav? I think the button in the hero section is a pretty good call to action. |
oh, I think we can remove the “Register” link in the navbar, it’s redundant, it takes the user to cvent, which we don’t want. |
ok, @Urigo how about now? it's still over populated in my opinion too, but that's one less link now |
@YassinEldeeb The Conference Committee met this morning and we discussed the nav issue you & @Urigo highlighted. They have requested that:
They also want to combine the Partner and Sponsor pages, but I think that's a bigger PR. The group was unanimous though that we should not drop 'Register' from the top nav. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1704 (comment)
Thanks for your feedback @jorydotcom! I’ll apply the proposed changes in this PR. |
@Urigo @jorydotcom can you please review the current state of the PR? I have applied your suggestions. |
8bf90f0
to
26f8fce
Compare
Looks much better to me |
It looks so much better!! Thank you @dimaMachina !!!! <3 |
@YassinEldeeb one last comment, if I'm not on the main page and I click "Register", it doesn't do anything |
@Urigo fixed it |
thank you! |
No description provided.