Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight text issue fix #1979

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Highlight text issue fix #1979

merged 1 commit into from
Mar 19, 2025

Conversation

nooras
Copy link
Contributor

@nooras nooras commented Mar 18, 2025

Closes #1973

image

Description

Highlight text issue fix for dark-mode

@benjie Please review the pr. Let me know if any changes are required.

Copy link

vercel bot commented Mar 18, 2025

@nooras is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 9:05pm

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this fixes the link being completely invisible 🙌

If you're interested in raising a follow-up PR, the pink-on-pink of the link is still hard to read, it would be nice to have links revert to the plain text (non-link) colour when inside a text selection.

Thanks again!

@benjie benjie merged commit b563486 into graphql:source Mar 19, 2025
4 checks passed
@nooras
Copy link
Contributor Author

nooras commented Mar 22, 2025

Thanks; this fixes the link being completely invisible 🙌

If you're interested in raising a follow-up PR, the pink-on-pink of the link is still hard to read, it would be nice to have links revert to the plain text (non-link) colour when inside a text selection.

Thanks again!

Hi @benjie

I am trying to make a change for a link to non-link color when selected.
But its not working for all. Here its changing the Blue box color to that color which is I mentioned in css file.
Is it fine? or is there some other way?

Have added below css for selection:
color: rgba(51,65,85,var(--tw-text-opacity));

I have tried color: inherit as well but its not working. Can you please guide me to proceed?

image

@benjie
Copy link
Member

benjie commented Mar 22, 2025

Hi @nooras; your results in the screenshot look good to me. I'm afraid I can't advise you as I'm not particularly familiar with the method of styling the website.

@nooras
Copy link
Contributor Author

nooras commented Mar 24, 2025

Hi @nooras; your results in the screenshot look good to me. I'm afraid I can't advise you as I'm not particularly familiar with the method of styling the website.

Hi @benjie

Update:
The changes i have tried its not working for both!! Either its working for Dark mode/ Light mode. The css i have applied for light mode its not clearly visible for dark mode and vice versa.
Default style are coming from nextra framework that I am not able to override!!
If u have any other suggestion let me know.
Thanks

@benjie
Copy link
Member

benjie commented Mar 24, 2025

@dimaMachina Maybe you have some ideas regarding styling of selected links here? I'm suggesting that the link colour be made the same as the text colour when selected, not sure if that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback for “Introduction to GraphQL”
2 participants