-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight text issue fix #1979
Highlight text issue fix #1979
Conversation
@nooras is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; this fixes the link being completely invisible 🙌
If you're interested in raising a follow-up PR, the pink-on-pink of the link is still hard to read, it would be nice to have links revert to the plain text (non-link) colour when inside a text selection.
Thanks again!
Hi @benjie I am trying to make a change for a link to non-link color when selected. Have added below css for selection: I have tried |
Hi @nooras; your results in the screenshot look good to me. I'm afraid I can't advise you as I'm not particularly familiar with the method of styling the website. |
Hi @benjie Update: |
@dimaMachina Maybe you have some ideas regarding styling of selected links here? I'm suggesting that the link colour be made the same as the text colour when selected, not sure if that's possible. |
Closes #1973
Description
Highlight text issue fix for dark-mode
@benjie Please review the pr. Let me know if any changes are required.