adds traces for dataloaders #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+171
to
+172
| The span SHOULD be a child of the span that initiated the batch loading, | ||
| which is typically a resolver execution span. |
There was a problem hiding this comment.
You probably already discussed this during the meeting, but I'm not sure to understand this part.
What does "initiated the batch loading" ? Is it the last or the first resolver that called this DataLoader ?
And this means that other resolvers spans will not have anything to do with this span. Should we specify that the DataLoader span should be linked to every resolver spans involved in the batch ? Because a common need is to being able to track down which resolver triggered a DataLoader batch.
| The span SHOULD be a child of the span that initiated the batch loading, | ||
| which is typically a resolver execution span. | ||
| attributes: |
There was a problem hiding this comment.
I think that would be useful to also know the number of cache miss/hit isn't it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.