[v18] Improve reliability of waitForSessionToBeEstablished #61780
+83
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several integration tests make use of the function to know that a session was created, a SessionTracker was created in the backend, and to retrieve the session id. The function polled the backend for session trackers until the context deadline set in individual tests was exceeded. In an effort to reduce flakiness and make the API easier for callers the helper has been rewritten. It now leverages a require.Eventually internally, has a hardcoded limit of 30s instead of allowing each test to define their own, and validates the number of expected participants in a session. Closes #17224. Closes #36959.
rosstimothy
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #61736 to branch/v18