[v18] Support and use the Go 1.25 testing/synctest API in tests #61783
+280
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
github-actions
bot
requested review from
boxofrad,
danielashare,
probakowski and
timothyb89
zmb3
approved these changes
Nov 26, 2025
hugoShaka
approved these changes
Nov 26, 2025
public-teleport-github-review-bot
bot
removed request for
boxofrad,
danielashare,
probakowski and
timothyb89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
synctestpackage inlib/utils/testutilsthat mimics the synctest package in go 1.24 if the synctest experiment is enabled or skips the test otherwise.A followup PR will do the same work for the tests in e that use synctest.