[v18] Port gcp join method to new join service (#61205)
#61797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port `gcp` join method to new join service This ports the `gcp` join method to the new join service. It moves join-related code from `lib/gcp` to `lib/join/gcp`, extracts common joining logic to `lib/join/gcp` for reuse between the legacy and new entrypoints, and adds a compatibility layer for use by the legacy client. See also: [RFD 27e](https://github.com/gravitational/teleport.e/blob/master/rfd/0027e-auth-assigned-uuids.md) * Add GCP to new join service whitelist * Rename checkAndSetDefaults() to validate()
timothyb89
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61205 for branch/v18
Retested against a Cloud tenant running this branch and a GCP VM:
gcpjoin method to new join serviceThis ports the
gcpjoin method to the new join service. It moves join-related code fromlib/gcptolib/join/gcp, extracts common joining logic tolib/join/gcpfor reuse between the legacy and new entrypoints, and adds a compatibility layer for use by the legacy client.See also: RFD 27e
Add GCP to new join service whitelist
Rename checkAndSetDefaults() to validate()