-
Notifications
You must be signed in to change notification settings - Fork 2k
tctl: Add support for rm okta_assignment #62391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a441b51 to
cc555da
Compare
|
This is fine, but one of the quality goals I want us to focus on going forward is completeness. It feels like users may be confused if we allow Additionally, we're in the middle of converting the tctl resource commands to the new handler format (#60370). This PR adds new resources to the old way of doing things, making more work for us to go back and convert. Any reason not to spend a little bit more time adding support for |
|
Just saying, we support |
zmb3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saying, we support tctl get okta_assignment for a very long time now.
Gotcha, I didn't realize that was the case. I'm fine with this for a quick fix then.
(As a side note, I noticed that running tctl get okta_assignment against an OSS cluster returns an unknown service error instead of an error explaining that this is an enterprise feature.)
|
@kopiczko a gentle holiday ping. This seems to be ready to be merged. |
|
I'm merging this now as is to help with fixing the customer's issue. I made a note to revisit and align it with the new approach during one of my support shifts. |
Backports:
changelog: Added
tctlsupport for removingokta_assingmentinternal resource should it be needed.