Skip to content

Conversation

@kopiczko
Copy link
Contributor

@kopiczko kopiczko commented Dec 19, 2025

Backports:

changelog: Added tctl support for removing okta_assingment internal resource should it be needed.

@kopiczko kopiczko marked this pull request as ready for review December 19, 2025 12:35
@github-actions github-actions bot added size/sm tctl tctl - Teleport admin tool labels Dec 19, 2025
@github-actions github-actions bot requested review from avatus and kshi36 December 19, 2025 12:36
@kopiczko kopiczko force-pushed the kopiczko/tctl_rm_okta_assignment branch from a441b51 to cc555da Compare December 19, 2025 12:36
@kopiczko kopiczko requested a review from smallinsky December 19, 2025 12:37
@zmb3
Copy link
Collaborator

zmb3 commented Dec 19, 2025

This is fine, but one of the quality goals I want us to focus on going forward is completeness.

It feels like users may be confused if we allow tctl rm foo but not tctl get foo.

Additionally, we're in the middle of converting the tctl resource commands to the new handler format (#60370). This PR adds new resources to the old way of doing things, making more work for us to go back and convert.

Any reason not to spend a little bit more time adding support for okta_assignment using the new resources pattern and supporting more verbs other than rm?

@kopiczko
Copy link
Contributor Author

Just saying, we support tctl get okta_assignment for a very long time now. I'll see how much time is to rework this, but it should be noted this PR is to solve a support issue and I think it has a marginal impact on the command conversion itself.

Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying, we support tctl get okta_assignment for a very long time now.

Gotcha, I didn't realize that was the case. I'm fine with this for a quick fix then.

(As a side note, I noticed that running tctl get okta_assignment against an OSS cluster returns an unknown service error instead of an error explaining that this is an enterprise feature.)

@milos-teleport
Copy link
Contributor

@kopiczko a gentle holiday ping. This seems to be ready to be merged.

@kopiczko kopiczko added this pull request to the merge queue Jan 8, 2026
@kopiczko
Copy link
Contributor Author

kopiczko commented Jan 8, 2026

I'm merging this now as is to help with fixing the customer's issue. I made a note to revisit and align it with the new approach during one of my support shifts.

Merged via the queue into master with commit 96156cf Jan 8, 2026
43 of 44 checks passed
@kopiczko kopiczko deleted the kopiczko/tctl_rm_okta_assignment branch January 8, 2026 10:03
@backport-bot-workflows
Copy link
Contributor

@kopiczko See the table below for backport results.

Branch Result
branch/v18 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants