chore(deps): bump the electron group across 1 directory with 5 updates #62704
Conversation
--- updated-dependencies: - dependency-name: node-pty dependency-version: 1.1.0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: electron - dependency-name: electron dependency-version: 39.2.7 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: electron - dependency-name: electron-builder dependency-version: 26.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: electron - dependency-name: electron-updater dependency-version: 6.7.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: electron - dependency-name: electron-vite dependency-version: 5.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: electron ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
avatus,
gzdunek,
r0mant,
ravicious and
zmb3
as code owners
dependabot
bot
added
ui
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
web/packages/teleterm/package.json
Outdated
| "@types/which": "^3.0.4", | ||
| "node-forge": "^1.3.3", | ||
| "node-pty": "1.1.0-beta35", | ||
| "node-pty": "1.1.0", |
There was a problem hiding this comment.
1.1.0 is still susceptible to the dev build error on macOS unfortunately.
The fix for it (microsoft/node-pty#850) has been shipped in 1.2.0-beta.2. I think we should just update to it since we've been using a beta version of this package all this time anyway.
There was a problem hiding this comment.
With 1.2.0-beta.2, the build now fails with this:
⨯ Detected file "Contents/Resources/app.asar.unpacked/node_modules/node-pty/prebuilds/darwin-arm64/pty.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "Contents/MacOS/tsh.app/Contents/MacOS/tsh"
atmakeUniversalApp(/Users/runner/work/teleport.e/teleport.e/node_modules/.pnpm/@[email protected]/node_modules/@electron/universal/src/index.ts:181:17)
It looks like since some version of node-pty that's > 1.1.0-beta35, the node-pty package ships with a prebuilds directory. You can see it here: https://www.npmjs.com/package/node-pty/v/1.2.0-beta.2?activeTab=code
I created an issue in node-pty about this as I'm not sure if @electron/universal is supposed to ignore those files or not. microsoft/node-pty#863
There was a problem hiding this comment.
This is how the system works currently. I recommend deleting the binaries that aren't relevant in the meantime. I'd like us to ship per-arch modules eventually.
@gzdunek Do you know off the top of your head how complex this would be? Because I'm weighing whether we should update or stay on 1.1.0-beta35 for a while.
I imagine it's going to include one of the build hooks and an annoying back-and-forth until we figure out which one runs at the correct stage of packaging the app. Though maybe it'd be a matter of adding console.log to all of them and then figuring out how to remove the unnecessary binaries.
There was a problem hiding this comment.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions