Fix Lint (Proto) path filters #62707
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
force-pushed
the
paul.gottschling/2026-01-08-resource-ref-filter
branch
from
2c3c04b to
45b8e38
Compare
Contributor
Author
|
Example of a failure related to the appropriately configured path filter: https://github.com/gravitational/teleport/actions/runs/20822630955/job/59815168824?pr=62707#step:11:9 |
ptgott
requested review from
camscale,
doggydogworld,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
rosstimothy
reviewed
Jan 8, 2026
.github/workflows/lint.yaml
Outdated
| - 'docs/pages/reference/infrastructure-as-code/terraform-provider/**' | ||
| - 'docs/pages/reference/infrastructure-as-code/teleport-resources/**' | ||
| - 'examples/chart/teleport-cluster/charts/teleport-operator/operator-crds' | ||
| - 'build.assets/tooling/cmd/resource-ref-generator/config.yaml' |
Contributor
There was a problem hiding this comment.
Is changing the config file the only thing we should be concerned with here? What if I changed any of the resource-ref-generator code?
Check whether the resource reference was generated correctly. Currently, we never execute the step called `Check if resource reference docs are up to date` if a PR updates the resource reference generator configuration or code. Also edit the resource reference generator config so re-running the generator would not produce diffs.
ptgott
force-pushed
the
paul.gottschling/2026-01-08-resource-ref-filter
branch
from
45b8e38 to
811a418
Compare
ptgott
added
the
no-changelog
rosstimothy
approved these changes
Jan 9, 2026
zmb3
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the resource reference was generated correctly. Currently, we never execute the step called
Check if resource reference docs are up to dateif a PR updates the resource reference generator configuration.Also edit the resource reference generator config so re-running the generator would not produce diffs.