[mcp] replace SSE event parser with logic from official go-sdk #62713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
changed the title
codingllama
approved these changes
Jan 8, 2026
|
|
||
| // empty reports whether the Event is empty. | ||
| func (e event) empty() bool { | ||
| return e.name == "" && e.id == "" && len(e.data) == 0 && e.retry == "" |
Contributor
There was a problem hiding this comment.
So close to return e == event{}, yet so far. (No action required.)
| // https://github.com/modelcontextprotocol/go-sdk/blob/a225d4dc7ded92f5492651a1bc60499b3be27044/mcp/event.go#L44 | ||
| var b bytes.Buffer | ||
| if e.name != "" { | ||
| fmt.Fprintf(&b, "event: %s\n", e.name) |
Contributor
There was a problem hiding this comment.
Separate write calls would be better. The types are all string or []byte, so there's not even need for strconv and the likes.
b.WriteString("event : ")
b.WriteString(e.name)
b.WriteRune('\n')OK to push back if you'd rather keep it like the original.
| ) | ||
|
|
||
| // event is an event is a server-sent event. | ||
| // Copied from official go-sdk with minor modification (make all fields private): |
Contributor
There was a problem hiding this comment.
Any chance we could move all the copied code in its owns files, separate from stuff we've written ourselves?
Tener
approved these changes
Jan 9, 2026
public-teleport-github-review-bot
bot
removed request for
bl-nero and
gabrielcorado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #62334
changelog: fix an issuse
MCP Session Listenevents may spam audit log with service errormalformed line in SSE stream: ""there is a bug in the current SSE event reader. this change replace it with the latest code from the official go-sdk:
https://github.com/modelcontextprotocol/go-sdk/blob/main/mcp/event.go
(unfortunately we cannot call the function directly atm)
besides copying some tests from the SDK, all existing tests also passed. and manually tested that the bug no longer happens.