[v18] Azure VM discovery: stats, refactor, add test coverage #62731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2210) * Refactor cloud instance watchers to use generic Fetcher interface * Correct channel initialization order * fix license corruption * remove redundant channel initialization * Refactor watcher to use utils.SyncMap * Increase timeout duration * Simplify setup * remove TODO * Update lib/srv/server/watcher.go Co-authored-by: Marco Dinis <[email protected]> * document NewWatcher function in watcher.go * Document SetFetchers and DeleteFetchers methods. * Remove unused parameter from NewWatcher function in EC2 watcher test * Update lib/srv/discovery/discovery_test.go Co-authored-by: Chris Thach <[email protected]> * Update lib/srv/server/watcher.go Co-authored-by: Chris Thach <[email protected]> * Update lib/srv/discovery/discovery_test.go Co-authored-by: Chris Thach <[email protected]> * Use utils.SyncMap instead of *utils.SyncMap * `AzureInstances` -> `*AzureInstances` * `EC2Instances` -> `*EC2Instances` * `GCPInstances` -> `*GCPInstances` * Fix initialization race condition. * post-merge fixes --------- Co-authored-by: Marco Dinis <[email protected]> Co-authored-by: Chris Thach <[email protected]>
* Azure VM discovery stats: proto changes * Azure VM discovery: stats, refactor, add test coverage * refactor: update Azure VM enrollment to return detailed failure information, change constant names for clarity. * update test * Update lib/srv/server/azure_installer.go Co-authored-by: Noah Stride <[email protected]> * flip if/else to decrease depth. * refactor: cache static fetchers in Azure server discovery --------- Co-authored-by: Noah Stride <[email protected]>
Tener
requested review from
atburke,
marcoandredinis and
strideynet
and removed request for
aadc-dev and
probakowski
atburke
approved these changes
Jan 9, 2026
marcoandredinis
approved these changes
Jan 9, 2026
Base automatically changed from
tener/backport-62210-branch/v18
to
branch/v18
January 10, 2026 19:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #62513 to branch/v18
Depends on #62730.
Changelog: Azure VM discovery will wait for installation and collect potential errors. The results will update discovery config statistics.