Skip to content

Conversation

@cthach
Copy link
Contributor

@cthach cthach commented Jan 9, 2026

Resolves #61551

Naive implementation currently committed. Once TODOs are resolved, this PR will be opened for review.

TODOs

  • Add test case if there is an error fetching from storage
  • Make buf accept the breaking-not-actually-breaking API change (shhh buf it's OK)
  • Polish
  • Update this description for reviewers

@cthach cthach self-assigned this Jan 9, 2026
@cthach cthach added mfa Issues related to Multi Factor Authentication no-changelog Indicates that a PR does not require a changelog entry labels Jan 9, 2026
@cthach cthach changed the title Implement MFAService VerifyValidatedMFAChallenge RPC handler. Implement MFAService VerifyValidatedMFAChallenge RPC handler Jan 9, 2026
@cthach cthach changed the title Implement MFAService VerifyValidatedMFAChallenge RPC handler WIP: Implement VerifyValidatedMFAChallenge RPC handler - DO NOT REVIEW Jan 9, 2026
@cthach cthach changed the title WIP: Implement VerifyValidatedMFAChallenge RPC handler - DO NOT REVIEW WIP: Implement VerifyValidatedMFAChallenge RPC handler - DO NOT REVIEW 🛑 Jan 9, 2026
@cthach cthach force-pushed the cthach/verify-mfa-challenge-rpc branch from a3b8206 to 206ad8d Compare January 9, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mfa Issues related to Multi Factor Authentication no-changelog Indicates that a PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the MFAService's VerifyValidatedMFAChallenge RPC

2 participants