Skip to content

Update neutral alert to match design #62749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmb3 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Update neutral alert to match design #62749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions web/packages/design/src/Alert/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export const Alert = ({
wrapContents = false,
...otherProps
}: AlertProps) => {
const alertIconSize = kind === 'neutral' ? 'large' : 'small';
const alertIconSize = 'small';
const [dismissed, setDismissed] = useState(false);

const onDismissClick = () => {
Expand Down Expand Up @@ -324,7 +324,8 @@ const iconContainerStyles = ({
case 'neutral':
return {
color: theme.colors.text.main,
background: 'none',
background: theme.colors.interactive.tonal.neutral[0],
padding: `${theme.space[2]}px`,
};
}
};
Expand Down Expand Up @@ -387,7 +388,7 @@ const ActionButtons = ({
)}
{secondaryAction && (
<ActionButton
fill="minimal"
fill={kind === 'neutral' ? 'filled' : 'minimal'}
intent="neutral"
action={secondaryAction}
/>
Expand Down
Loading