Add client_ip_restriction to Terraform provider#68151
Draft
mcbattirola wants to merge 2 commits into
Draft
Conversation
mcbattirola
added
the
no-changelog
Contributor
|
Amplify deployment status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for managing
client_ip_restrictionvia Terraform.RFD: 0226 - Client IP Restrictions API
Note that CIR will use polling state changes, which were implemented in #63520, but only the template for plural resources was updated at the time. This is why we had to update the
integrations/terraform/gen/singular_resource.go.tpltemplate here.Manual Test Plan
Test Environment
Test Cases
Contributes to https://github.com/gravitational/cloud/issues/17214