Skip to content

Fixes: v1.5.1#3927

Open
VishalDalwadi wants to merge 2 commits intodevelopfrom
fixes/v1.5.1
Open

Fixes: v1.5.1#3927
VishalDalwadi wants to merge 2 commits intodevelopfrom
fixes/v1.5.1

Conversation

@VishalDalwadi
Copy link
Collaborator

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@tenki-reviewer
Copy link

VishalDalwadi does not have a Code Reviewer seat assigned. You can manage seats in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants