Skip to content

fix(dgeni): members deeply nested in inheritance chain not hoisted - #4240

Merged
griest024 merged 5 commits into
graycoreio:developfrom
griest024:fix/dgeni/size-missing-from-button
Jan 14, 2026
Merged

fix(dgeni): members deeply nested in inheritance chain not hoisted#4240
griest024 merged 5 commits into
graycoreio:developfrom
griest024:fix/dgeni/size-missing-from-button

Conversation

@griest024

Copy link
Copy Markdown
Member

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #3817
Part of: #

New behavior

Breaking change?

  • Yes
  • No

Additional context

@griest024
griest024 requested a review from a team as a code owner December 5, 2025 19:00
@griest024

Copy link
Copy Markdown
Member Author

@xelaint I just need an acceptance test from you

@griest024
griest024 requested a review from xelaint December 5, 2025 19:00
@griest024

griest024 commented Dec 11, 2025

Copy link
Copy Markdown
Member Author

outstanding issues are:

  • defaultSize is hoisted when it shouldn't be: investigate input/output name filter
  • size type is T when it should be filled with the concrete type

@griest024
griest024 force-pushed the fix/dgeni/size-missing-from-button branch from edf4ad8 to 9380bf5 Compare December 17, 2025 01:21
@griest024

Copy link
Copy Markdown
Member Author

@xelaint ready for review

@xelaint

xelaint commented Dec 17, 2025

Copy link
Copy Markdown
Member

@griest024 I'm still seeing defaultSize in the DaffButtonSizableDirective docs.

@griest024

Copy link
Copy Markdown
Member Author

@griest024 I'm still seeing defaultSize in the DaffButtonSizableDirective docs.

it should be there, correct? DaffButtonSizableDirective extends DaffSizableDirective and therefore inherits all of its properties. Contrasted to DaffButtonComponent which only inherits size through hostDirectives.

The type of defaultSize is wrong however, I need to fix that.

@xelaint

xelaint commented Dec 17, 2025

Copy link
Copy Markdown
Member

@griest024 I don't think so? defaultSize is not a property that can be changed in button. It should not be part of the public api.

@griest024

Copy link
Copy Markdown
Member Author

@griest024 I don't think so? defaultSize is not a property that can be changed in button. It should not be part of the public api.

should it marked @docs-private then?

@xelaint

xelaint commented Dec 18, 2025

Copy link
Copy Markdown
Member

@griest024 I don't think so? defaultSize is not a property that can be changed in button. It should not be part of the public api.

should it marked @docs-private then?

It still needs to be in the public api for DaffSizableDirective. I tried to mark this as docs-private, but it doesn't do anything.

 /**
     * @docs-private
     * Sets the default size of a button to medium.
     */
    this.size.defaultSize = 'md';
    ```

@griest024
griest024 force-pushed the fix/dgeni/size-missing-from-button branch from 9380bf5 to 5a14a2b Compare January 13, 2026 17:15
@griest024
griest024 requested a review from a team as a code owner January 13, 2026 17:15
@griest024

Copy link
Copy Markdown
Member Author

@xelaint okay those issues should be fixed

@griest024
griest024 merged commit 7139f8c into graycoreio:develop Jan 14, 2026
16 checks passed
@gray-bot gray-bot mentioned this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The size property is missing from Button's API docs

2 participants