Skip to content

feat(driver)!: add feature support to magento driver provider #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
griest024 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(driver)!: add feature support to magento driver provider #4251

griest024 wants to merge 2 commits into from

Conversation

@griest024
Copy link
Member

@griest024 griest024 commented Dec 10, 2025 •
edited
Loading

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

New behavior

makes provideMagentoDriver configable with features

Breaking change?

  • Yes
  • No

Additional context

@griest024 griest024 requested a review from a team as a code owner December 10, 2025 15:16
damienwebdev
damienwebdev requested changes Dec 10, 2025
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change against @daffodil/commerce.

See: https://github.com/graycoreio/daffodil/blob/develop/tools/schematics/ng-add/generators/providers/standalone.ts#L140

We'll need to adjust this usage and validate that @daffodil/commerce 's Magento schematic works as expected.

@griest024
Copy link
Member Author

griest024 commented Dec 10, 2025

This is a breaking change against @daffodil/commerce.

See: https://github.com/graycoreio/daffodil/blob/develop/tools/schematics/ng-add/generators/providers/standalone.ts#L140

We'll need to adjust this usage and validate that @daffodil/commerce 's Magento schematic works as expected.

ah yes we should really have test cases for this: #4253

@griest024 griest024 changed the title feat(driver): add feature support to magento driver provider feat(driver)!: add feature support to magento driver provider Dec 10, 2025
@griest024 griest024 requested a review from a team as a code owner December 10, 2025 20:38
@griest024
Copy link
Member Author

griest024 commented Dec 10, 2025

@damienwebdev should be fixed now

@griest024 griest024 added the status: pending review This PR is awaiting review or response from a reviewer before the author can proceed. label Dec 11, 2025
@griest024 griest024 force-pushed the feat/driver/magento/add-feature-support-to-provbider branch from b408444 to ff6aa43 Compare January 7, 2026 23:09
@griest024 griest024 mentioned this pull request Jan 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

Requested changes must be addressed to merge this pull request.

Assignees

@damienwebdev damienwebdev

Labels

status: pending review This PR is awaiting review or response from a reviewer before the author can proceed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@griest024 @damienwebdev