Skip to content

Conversation

@joannalauu
Copy link
Contributor

@joannalauu joannalauu commented Jan 7, 2026

This also deprecates the DaffMenuModule.

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #3513

Developed on top of #3569

New behavior

  • Truncates breadcrumbs into an overflow menu on mobile and when more than five items are present on desktop
  • Deprecates DaffMenuModule

Breaking change?

  • Yes
  • No

Additional context

@joannalauu joannalauu requested review from a team as code owners January 7, 2026 18:19
@xelaint
Copy link
Member

xelaint commented Jan 8, 2026

Blocked by #3998 (needs to be merged before this)

@xelaint xelaint added package: design @daffodil/design status: pending review This PR is awaiting review or response from a reviewer before the author can proceed. labels Jan 8, 2026
Copy link
Member

@xelaint xelaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's fully working. This is what I see when I open menu in mobile, close it, then go back to desktop view.

Image

To repro:

  1. Update viewport to mobile
  2. Click on ... to open menu
  3. Close menu
  4. Go back to desktop viewport

<ng-template #fullMenu>
<daff-menu>
@for (breadcrumbItem of _fullMenuItems(); track breadcrumbItem; let index = $index) {
<button daff-menu-item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ability to choose between a <button daff-menu-item> or <a daff-menu-item> and pass in the link to the daff-menu-item.

This structure is bad:
Image

This should be:

<a daff-menu-item href="/docs">
  <div class="daff-menu-item__content">
    Docs
  </div>
</a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been able to find a good solution to achieve this without breaking other behaviour.

Right now, the breadcrumb is passed into the menu through
<ng-container [ngTemplateOutlet]="breadcrumbItem.itemRef"></ng-container>
as <a href="/docs">Docs</a>, and there isn't really a way to extract the href and innerHTML while keeping the menu content up-to-date, because the menu is usually not re-rendered when switched to another page.

Perhaps it might be better to just keep the structure as it is, even through it isn't ideal? Please let me know if you have any ideas on an effective solution to this.

@joannalauu joannalauu force-pushed the feat/breadcrumb-truncate branch from 1f98924 to 147afb4 Compare January 8, 2026 20:58
@joannalauu joannalauu requested a review from xelaint January 8, 2026 22:13
Copy link
Member

@xelaint xelaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things breaking:

  1. active is no longer set on the active breadcrumb item
  2. breadcrumb items are not being rendered correctly on page change
Screen.Recording.2026-01-09.at.11.09.20.AM.mov

@joannalauu joannalauu force-pushed the feat/breadcrumb-truncate branch 2 times, most recently from 63834e9 to 4b6e3f4 Compare January 9, 2026 22:31
@joannalauu joannalauu force-pushed the feat/breadcrumb-truncate branch from 4b6e3f4 to 5704534 Compare January 9, 2026 22:39
@joannalauu
Copy link
Contributor Author

joannalauu commented Jan 9, 2026

@xelaint I really sorry about not thoroughly review my code before requesting a review. I have fixed the breadcrumb behaviour to work as intended, aside from the daff-menu structure which I have elaborated more in the discussion thread.

@joannalauu joannalauu requested a review from xelaint January 15, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: design @daffodil/design status: pending review This PR is awaiting review or response from a reviewer before the author can proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Add truncated design and support for injecting the DaffMenuModule to DaffBreadcrumbComponent

3 participants