-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat(design): Add truncated design to DaffBreadcrumbComponent #4278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Blocked by #3998 (needs to be merged before this) |
xelaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <ng-template #fullMenu> | ||
| <daff-menu> | ||
| @for (breadcrumbItem of _fullMenuItems(); track breadcrumbItem; let index = $index) { | ||
| <button daff-menu-item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not been able to find a good solution to achieve this without breaking other behaviour.
Right now, the breadcrumb is passed into the menu through
<ng-container [ngTemplateOutlet]="breadcrumbItem.itemRef"></ng-container>
as <a href="/docs">Docs</a>, and there isn't really a way to extract the href and innerHTML while keeping the menu content up-to-date, because the menu is usually not re-rendered when switched to another page.
Perhaps it might be better to just keep the structure as it is, even through it isn't ideal? Please let me know if you have any ideas on an effective solution to this.
1f98924 to
147afb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few things breaking:
activeis no longer set on the active breadcrumb item- breadcrumb items are not being rendered correctly on page change
Screen.Recording.2026-01-09.at.11.09.20.AM.mov
63834e9 to
4b6e3f4
Compare
4b6e3f4 to
5704534
Compare
|
@xelaint I really sorry about not thoroughly review my code before requesting a review. I have fixed the breadcrumb behaviour to work as intended, aside from the daff-menu structure which I have elaborated more in the discussion thread. |


This also deprecates the DaffMenuModule.
PR Checklist
PR Type
Current behavior
Fixes: #3513
Developed on top of #3569
New behavior
Breaking change?
Additional context