refactor: Replace caching logic with defaultMemoize for selector factories
#4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannalauu
force-pushed
the
feat/defaultMemoize-cache
branch
from
fa3dba9 to
8b82879
Compare
griest024
reviewed
Jan 12, 2026
Member
griest024
left a comment
griest024
left a comment
There was a problem hiding this comment.
looks mostly good, explicit typing reduces readability somewhat
Comment on lines
+25
to
+28
| export const getDaffCartFeatureSelector: < | ||
| T extends DaffCart = DaffCart, | ||
| V extends DaffCartOrderResult = DaffCartOrderResult, | ||
| >() => DaffCartFeatureMemoizedSelectors<T, V> = defaultMemoize(< |
Member
There was a problem hiding this comment.
Is it necessary to explicitly type getDaffCartFeatureSelector here? Does memoized not have the correct type?
Contributor
Author
There was a problem hiding this comment.
There were errors with the implicit type not being recognized when importing the selector to another function, which is why I added explicit types to all the imports.
Member
There was a problem hiding this comment.
ah yes,
function defaultMemoize(projectionFn: AnyFn, ...)ngrx does not type defaultMemoize strongly enough
griest024
requested changes
Jan 15, 2026
Member
griest024
left a comment
griest024
left a comment
There was a problem hiding this comment.
code lgtm but needs signed commits
Signed-off-by: Joanna Lau <[email protected]>
joannalauu
force-pushed
the
feat/defaultMemoize-cache
branch
from
8b82879 to
68b976f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #2109
New behavior
Selector factories now use
defaultMemoizefor cachingBreaking change?
Additional context