Skip to content

feat(commerce): daff.json specifies driver version for angular.json - #4452

Open
joannalauu wants to merge 11 commits into
developfrom
feat/daff-json
Open

feat(commerce): daff.json specifies driver version for angular.json#4452
joannalauu wants to merge 11 commits into
developfrom
feat/daff-json

Conversation

@joannalauu

@joannalauu joannalauu commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #4437

New behavior

Breaking change?

  • Yes
  • No

Additional context

claude was using in the making of this PR.

no docs yet and needs to be pieced up for final merging but is ready for a review of the general idea and functionality

Comment thread tools/schematics/ng-add/generators/daff-config/daff-config.ts Outdated
@griest024
griest024 force-pushed the feat/daff-json branch 3 times, most recently from aaca7f3 to 13b3378 Compare May 27, 2026 22:27
@griest024

Copy link
Copy Markdown
Member

blocked by graycoreio/github-actions#19

@griest024
griest024 marked this pull request as ready for review May 29, 2026 20:38
@griest024
griest024 requested review from a team as code owners May 29, 2026 20:38
@griest024
griest024 force-pushed the feat/daff-json branch 4 times, most recently from dfcfab5 to 0a23f16 Compare June 10, 2026 17:24
griest024
griest024 previously approved these changes Jun 10, 2026
griest024
griest024 previously approved these changes Aug 3, 2026

@griest024 griest024 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damienwebdev I've implemented the builders

Comment thread angular.json Outdated
"architect": {
"build": {
"builder": "@angular/build:application",
"builder": "./dist/commerce:application",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread apps/daffio/package.json Outdated
},
"devDependencies": {
"@daffodil/branding": "0.0.0-PLACEHOLDER",
"@daffodil/commerce": "0.0.0-PLACEHOLDER",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@griest024
griest024 marked this pull request as draft August 3, 2026 16:21
@griest024

Copy link
Copy Markdown
Member

@damienwebdev hang on I'm fixing the schematic

@griest024
griest024 marked this pull request as ready for review August 3, 2026 18:55
@griest024

Copy link
Copy Markdown
Member

@damienwebdev ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define a daff.json that specifies driver version for angular.json

3 participants