Skip to content

docs(design): clarify light and dark color behavior #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xelaint merged 1 commit into from
Aug 5, 2026
+11 −3
Merged

docs(design): clarify light and dark color behavior #4633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/design/progress-bar/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Use an indeterminate progress bar when the percentage of completion is unknown o
### Colors
The default color is `primary`. Use the `color` property to change a progress bar's color.

> `theme`, `white`, and `black` should be used with caution to ensure that there is sufficient contrast.
> `theme`, `light`, and `dark` should be used with caution to ensure that there is sufficient contrast.

<daff-docs-example-viewer example="progress-bar-themes"></daff-docs-example-viewer>

Expand Down
12 changes: 10 additions & 2 deletions libs/design/src/core/colorable/colorable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,20 @@ export enum DaffColorEnum {
Tertiary = 'tertiary',

/**
* A light color that does not change based on the theme.
* A light color.
*
* This does not track the theme mode. An element with this color stays light
* in both light and dark mode. Use `Theme` or `ThemeContrast` instead for a
* color that flips with the mode.
*/
Light = 'light',

/**
* A dark color that does not change based on the theme.
* A dark color.
*
* This does not track the theme mode. An element with this color stays dark
* in both light and dark mode. Use `Theme` or `ThemeContrast` instead for a
* color that flips with the mode.
*/
Dark = 'dark',

Expand Down
Loading