Fix benchmark client #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2020 14:19
grcevski
force-pushed
the
fix-benchmark-client
branch
from
bc68f08 to
2eb1e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the PinotThroughput benchmark client, where if an exception happens while running a http request to the Pinot benchmark cluster, the driver will not close the connection and eventually we'll run out of socket handles. This bug seems to affect MacOS and Windows only.
The fix simply moves the httpRequest into a try region and consumes the response to simulate more accurate workload.
The benchmark cluster also seems to fail to start because of a NullPointerException in PinotHelixResourceManager. There's probably a better fix here, we'll need some help to do it properly. For now, so we can make progress we simply checked against the nullness of the instanceConfig.
Co-authored-by: @grcevski @charliegracie @macarte @adityamandaleeka