Skip to content

Reuse temporary bytebuffer in loop #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grcevski wants to merge 1 commit into
base: parse-query-cache
Choose a base branch
from
Open

Reuse temporary bytebuffer in loop #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,23 +387,27 @@ public Map<Object, Object> deserialize(ByteBuffer byteBuffer) {
if (size == 0) {
return map;
}
ByteBuffer temp = byteBuffer.duplicate();

// De-serialize each key-value pair
int keyTypeValue = byteBuffer.getInt();
int valueTypeValue = byteBuffer.getInt();
for (int i = 0; i < size; i++) {
Object key = ObjectSerDeUtils.deserialize(sliceByteBuffer(byteBuffer, byteBuffer.getInt()), keyTypeValue);
Object value = ObjectSerDeUtils.deserialize(sliceByteBuffer(byteBuffer, byteBuffer.getInt()), valueTypeValue);
Object key = ObjectSerDeUtils.deserialize(slideByteBuffer(byteBuffer, temp, byteBuffer.getInt()), keyTypeValue);
Object value = ObjectSerDeUtils.deserialize(slideByteBuffer(byteBuffer, temp, byteBuffer.getInt()), valueTypeValue);
map.put(key, value);
}
return map;
}

private ByteBuffer sliceByteBuffer(ByteBuffer byteBuffer, int size) {
ByteBuffer slice = byteBuffer.slice();
slice.limit(size);
byteBuffer.position(byteBuffer.position() + size);
return slice;
private ByteBuffer slideByteBuffer(ByteBuffer byteBuffer, ByteBuffer temp, int size) {
int head = byteBuffer.position();
int tail = head + size;
temp.limit(tail);
temp.position(head);
byteBuffer.position(tail);

return temp;
}
};

Expand Down