Reuse bytebuffer when possible #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Charlie Gracie <[email protected]>
grcevski
force-pushed
the
fix-benchmark-client
branch
from
bc68f08 to
2eb1e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance by re-using ByteByffer array
During String deserialization the ByteBuffer array() can be resused
instead of creating a new byte[] and reading the data from the
ByteBuffer. If the ByteBuffer is not backed by an array creating
a new byte[] and reading the data is still required.
Performance measurement results:
Machine configuration:
4 core (8 threads) Intel(R) Xeon(R) W-2123 CPU @ 3.60GHz
32GB of RAM
Linux x86-64, kernel: 5.0.0-37-generic
Benchmark configuration:
TPC-H (optimal index)
20 clients
180s runtime
Results (QPS higher is better, response time lower is better)
Base with (trimming-results-refactor):
Time Passed: 180.013s, Query Executed: 617034, QPS: 3427.7191091754485, Avg Response Time: 5.82426738234846ms
Improved (this branch):
Time Passed: 180.012s, Query Executed: 633469, QPS: 3519.0376197142414, Avg Response Time: 5.674053505380689ms
Co-authored-by: @grcevski @charliegracie @macarte @adityamandaleeka