Skip to content

[DOCS] Put Cloud snippets under test #10831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

cdkini
Copy link
Contributor

@cdkini cdkini commented Jan 8, 2025

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 510e2ea
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67dcaca7d1726100084d580a

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (20abb22) to head (510e2ea).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10831   +/-   ##
========================================
  Coverage    80.32%   80.33%           
========================================
  Files          484      484           
  Lines        40972    40972           
========================================
+ Hits         32912    32913    +1     
+ Misses        8060     8059    -1     
Flag Coverage Δ
3.10 70.35% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.76% <ø> (ø)
3.10 aws_deps 46.56% <ø> (ø)
3.10 big 54.98% <ø> (ø)
3.10 bigquery ?
3.10 clickhouse 43.47% <ø> (ø)
3.10 databricks ?
3.10 filesystem 63.11% <ø> (ø)
3.10 mssql ?
3.10 mysql 52.10% <ø> (ø)
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 spark_connect ?
3.10 trino ?
3.11 70.36% <ø> (+<0.01%) ⬆️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.76% <ø> (ø)
3.11 aws_deps ?
3.11 big 54.98% <ø> (ø)
3.11 bigquery ?
3.11 clickhouse 43.47% <ø> (ø)
3.11 databricks ?
3.11 filesystem 63.11% <ø> (ø)
3.11 mssql ?
3.11 mysql 52.10% <ø> (ø)
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 spark_connect ?
3.11 trino ?
3.12 70.36% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.77% <ø> (ø)
3.12 aws_deps 46.56% <ø> (ø)
3.12 big 54.97% <ø> (ø)
3.12 bigquery 49.15% <ø> (ø)
3.12 databricks 50.80% <ø> (ø)
3.12 filesystem 63.11% <ø> (ø)
3.12 mssql 51.85% <ø> (ø)
3.12 mysql 52.10% <ø> (ø)
3.12 postgresql 54.77% <ø> (ø)
3.12 snowflake 51.57% <ø> (ø)
3.12 spark 58.04% <ø> (ø)
3.12 spark_connect 46.89% <ø> (ø)
3.12 trino 52.52% <ø> (ø)
3.9 70.38% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.77% <ø> (ø)
3.9 aws_deps 46.58% <ø> (ø)
3.9 big 54.99% <ø> (ø)
3.9 bigquery 49.14% <ø> (ø)
3.9 clickhouse 43.49% <ø> (ø)
3.9 databricks 50.80% <ø> (ø)
3.9 filesystem 63.11% <ø> (ø)
3.9 mssql 51.83% <ø> (ø)
3.9 mysql 52.08% <ø> (ø)
3.9 postgresql 54.75% <ø> (ø)
3.9 snowflake 51.57% <ø> (ø)
3.9 spark 58.00% <ø> (ø)
3.9 spark_connect 46.90% <ø> (ø)
3.9 trino 52.51% <ø> (ø)
cloud 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdkini
Copy link
Contributor Author

cdkini commented Jan 13, 2025

couldn't get this across the line but it's really close! there's an ECR issue or something take a look at the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants