[DOCS] ExpectAI approval workflow #11072
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #11072 +/- ##
========================================
Coverage 80.96% 80.96%
========================================
Files 487 487
Lines 41161 41161
========================================
Hits 33325 33325
Misses 7836 7836 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| :::note This might take a few minutes | ||
| ExpectAI may take a few minutes to analyze your data and recommend personalized Expectations. You can navigate away from the page while ExpectAI works in the background. GX will email you when your recommended Expectations are ready for review. | ||
| ::: | ||
| 4. Review the generated Expectations and **Approve** (✓) or **Reject** (✗) them within 48 hours. After that, the recommendations will be discarded. |
There was a problem hiding this comment.
| 4. Review the generated Expectations and **Approve** (✓) or **Reject** (✗) them within 48 hours. After that, the recommendations will be discarded. | |
| 4. Review the generated Expectations and **Approve** (✓) or **Reject** (✗) them within 48 hours. After that, any undecided recommendations will be discarded. |
My suggestion here isn't the best wording, but I'm wondering if we need to highlight that it's only the recommendations in the "non-approved & non-rejected" state that will be discarded?
That could be covered by the antecedent use of "recommendations" rather than "Expectations," but I wonder if people will possibly read it as discarding ExpectAI things they've already approved/rejected.
There was a problem hiding this comment.
Hmmm I see what you mean but something about "undecided" feels off to me - like it's describing the recommendation's state of mind rather than a lack of user action regarding the recommendation. Probably I just have a strong association of the word "undecided" and the term "undecided voter" in my mind. I'll make a different change in the spirit of this suggestion.
| 4. Review the generated Expectations and **Approve** (✓) or **Reject** (✗) them within 48 hours. After that, the recommendations will be discarded. | |
| 4. Review the recommended Expectations and **Approve** (✓) or **Reject** (✗) them within 48 hours. After 48 hours, any remaining recommendations will be discarded. |
There was a problem hiding this comment.
@klavavej Sorry I missed this! I didn't get the notification from github. And yes, totally agree with the associations between "undecided" and "undecided voter". I like the proposed changes you've got here.
There was a problem hiding this comment.
thanks! if everything looks good now, would you please approve this PR?
Resolves https://greatexpectations.atlassian.net/browse/DOC-1105 according to the plan linked in that issue
@netlify /docs/cloud/expectations/manage_expectations/#generate-expectations-with-expectai-beta
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!