[FEATURE] Add redshift datasource api decorator. #11097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #11097 +/- ##
===========================================
- Coverage 81.12% 79.19% -1.93%
===========================================
Files 499 499
Lines 41330 41332 +2
===========================================
- Hits 33528 32733 -795
- Misses 7802 8599 +797 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
billdirks
changed the title
billdirks
changed the title
dctalbot
approved these changes
Apr 15, 2025
klavavej
reviewed
Apr 16, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "title": "RedshiftDatasource", | |||
| "description": "Adds a redshift datasource to the data context using psycopg2.\n\nArgs:\n name: The name of this redshift datasource.\n connection_string: The SQLAlchemy connection string used to connect to the redshift\n database. This will use a redshift with psycopg2. For example:\n \"redshift+psycopg2://[email protected]:5439/database\"\n assets: An optional dictionary whose keys are TableAsset or QueryAsset names and whose\n values are TableAsset or QueryAsset objects.", | |||
| "description": "--Public API--Adds a redshift datasource to the data context using psycopg2.\n\nArgs:\n name: The name of this redshift datasource.\n connection_string: The SQLAlchemy connection string used to connect to the redshift\n database. This will use a redshift with psycopg2. For example:\n \"redshift+psycopg2://[email protected]:5439/database\"\n assets: An optional dictionary whose keys are TableAsset or QueryAsset names and whose\n values are TableAsset or QueryAsset objects.", | |||
There was a problem hiding this comment.
This is maybe the wrong place to apply these changes (looks like this is generated json?) but here's a suggestion that does a few things:
- capitalizes Redshift as a proper noun
- removes what appears to be some stray words (when compared to the similar page for postgres
Suggested change
| "description": "--Public API--Adds a redshift datasource to the data context using psycopg2.\n\nArgs:\n name: The name of this redshift datasource.\n connection_string: The SQLAlchemy connection string used to connect to the redshift\n database. This will use a redshift with psycopg2. For example:\n \"redshift+psycopg2://[email protected]:5439/database\"\n assets: An optional dictionary whose keys are TableAsset or QueryAsset names and whose\n values are TableAsset or QueryAsset objects.", | |
| "description": "--Public API--Adds a Redshift datasource to the data context using psycopg2.\n\nArgs:\n name: The name of this Redshift datasource.\n connection_string: The SQLAlchemy connection string used to connect to the Redshift\n database. For example:\n \"redshift+psycopg2://[email protected]:5439/database\"\n assets: An optional dictionary whose keys are TableAsset or QueryAsset names and whose\n values are TableAsset or QueryAsset objects.", |
There was a problem hiding this comment.
I wanted to double check the connection string format here since it's different that what I'm using in my docs PR based on feedback on my docs plan
This PR has
redshift+psycopg2://[email protected]:5439/database
My PR has
redshift+psycopg2://<USER_NAME>:<PASSWORD>@<HOST>:<PORT>/<DATABASE>?sslmode=<SSLMODE>
notable differences are:
- whether or not password is included
- whether or not SSL mode is included
Should the discrepancy between PRs be resolved? if yes, in what direction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!