[MAINTENANCE] Remove deprecated v0.13.28 V2 API style custom rendering#11833
[MAINTENANCE] Remove deprecated v0.13.28 V2 API style custom rendering#11833joshua-stauffer wants to merge 4 commits into
Conversation
The V2 API style custom rendering path was deprecated in v0.13.28 with a removal target of v0.16. We are now well past that window (current v1.16.1), so the fallback method and its companion helper are removed along with the test that exercised the deprecated path.
✅ Deploy Preview for niobium-lead-7998 canceled.
|
There was a problem hiding this comment.
Pull request overview
Removes the long-deprecated (v0.13.28) V2 API-style custom rendering fallback from the Data Docs validation results table renderer, aligning the renderer implementation with the current V3 rendering/registry mechanism used across the codebase.
Changes:
- Removed legacy V2 API-style expectation rendering fallback logic (and associated
DeprecationWarning) fromValidationResultsTableContentBlockRenderer. - Simplified observed value rendering to rely solely on registered
OBSERVED_VALUErenderers (fallback to"--"when absent). - Deleted the unit test that exclusively exercised the deprecated V2 custom rendering path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
great_expectations/render/renderer/content_block/validation_results_table_content_block.py |
Removes V2 legacy helper methods/import and legacy branching in _get_content_block_fn / observed value rendering. |
tests/render/test_render_ValidationResultsTableContentBlockRenderer.py |
Removes the test that validated the deprecated V2 API-style custom rendering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11833 +/- ##
===========================================
- Coverage 84.69% 84.67% -0.02%
===========================================
Files 471 471
Lines 39189 39170 -19
===========================================
- Hits 33190 33169 -21
- Misses 5999 6001 +2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The continue-on-error flag originally added in #11829 was dropped when #11822 refactored the pact-contract-check into its own job. Without it, PRs fail whenever Mercury has not verified the new consumer pact within the 10-minute retry window — which is a timing/infrastructure signal, not an indicator that the PR itself has regressed a contract.
This reverts commit 7e226d8.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyarrow 24.0.0 started shipping stubs that declare the top-level `pyarrow` as a specific Module subtype, making the `pyarrow = PYARROW_NOT_IMPORTED` fallback fail mypy's [assignment] check. The fallback only runs when the import fails, so silencing the assignment error with a targeted type-ignore matches the existing pattern elsewhere in this compatibility/ package.
Summary
Removes the V2 API style custom rendering fallback that was deprecated in v0.13.28 with a removal target of v0.16. We are now well past that removal window (current GX version is 1.16.1).
Removed:
ValidationResultsTableContentBlockRenderer._get_legacy_v2_api_style_expectation_string_fn— the classmethod holding theDeprecationWarning, whose entire purpose was to support V2 API style expectation rendering.ValidationResultsTableContentBlockRenderer._get_legacy_v2_api_observed_value— companion helper only meaningful for the deprecated path._get_content_block_fnthat branched to those helpers.warningsimport.test_ValidationResultsTableContentBlockRenderer_get_content_block_fn_with_v2_api_style_custom_rendering, the one test that solely exercised the deprecated path.Original deprecation message for context:
Test plan
great_expectations,cloud, andgx-runner; the removed symbols were only used internally within the file.