Increase sample rate fixed-point precision#1721
Merged
mossmann merged 3 commits intoApr 10, 2026
Merged
Conversation
655bbe4 to
9887d73
Compare
e0922c4 to
6532c46
Compare
Fix overflowing division in sample_rate_set Avoid overflows in round_sample_rate
6532c46 to
b76c875
Compare
mossmann
approved these changes
Apr 10, 2026
mossmann
left a comment
Member
There was a problem hiding this comment.
Very nice! I'm seeing a reduction of mean sample rate error of about five orders of magnitude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.