Fix: setting stack buffer to NULL #1733
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since buffer within pluginlaunch.c is within the stack it cannot be NULL. This fixes that oversight. I'm unsure why we even double check for the buffer to be empty when it is already indicated by len of fread.
nichtsfrei
force-pushed
the
fix-broken-pr
branch
from
d3a3901
to
f881d8b
Compare
github-actions
bot
added
patch_release
jjnicola
approved these changes
Oct 3, 2024
| @@ -411,7 +412,11 @@ get_available_memory () | |||
| } | |||
| len = fread (buf, 1, sizeof (buf) - 1, fd); | |||
There was a problem hiding this comment.
Hi there, @nichtsfrei
IMHO - Rather than just reading the file, I think it would be better to get the file size from the offset and then make sure that the fread() reads and check as normally as the file size 😆
How about you?
There was a problem hiding this comment.
It may not be too important, but char buf is using around 8192 of arbitrary unnecessary memory.
so I think it's good to get the file size and then read it that much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since buffer within pluginlaunch.c is within the stack it cannot be NULL. This fixes that oversight.
I'm unsure why we even double check for the buffer to be empty when it is already indicated by len of fread.