Skip to content

Conversation

@Oba-One
Copy link
Member

@Oba-One Oba-One commented Sep 21, 2025

  • Replaced Jest with Vitest as the testing framework, updating all related configurations and test files accordingly.
  • Deleted unused test setup files and Jest configuration to streamline the testing environment.
  • Introduced a new Vitest configuration file to support testing with React and TypeScript.
  • Updated various test files to utilize Vitest's mocking and assertion capabilities, ensuring compatibility with the new framework.
  • Removed deprecated utility functions and files to enhance code clarity and maintainability.

These changes improve the testing infrastructure and overall code quality of the Cookie Jar protocol.

- Added Playwright configuration for comprehensive E2E testing, including setup and teardown scripts.
- Created multiple test specifications covering basic functionality, accessibility, performance, and NFT gating.
- Introduced utility functions for wallet interactions and robust selector strategies to enhance test reliability.
- Updated package.json to include Playwright dependencies and new test scripts for easier execution.
- Added GitHub Actions workflow for automated E2E testing on push and pull request events.

These changes significantly improve the testing capabilities and reliability of the Cookie Jar protocol, ensuring a better user experience and code quality.
…ete files

- Replaced Jest with Vitest as the testing framework, updating all related configurations and test files accordingly.
- Deleted unused test setup files and Jest configuration to streamline the testing environment.
- Introduced a new Vitest configuration file to support testing with React and TypeScript.
- Updated various test files to utilize Vitest's mocking and assertion capabilities, ensuring compatibility with the new framework.
- Removed deprecated utility functions and files to enhance code clarity and maintainability.

These changes improve the testing infrastructure and overall code quality of the Cookie Jar protocol.
@vercel
Copy link

vercel bot commented Sep 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cookie-jar Ready Ready Preview Comment Sep 21, 2025 7:31pm

- Introduced a preinstall script in package.json to automate dependency checks and installations.
- Created a new install-deps.sh script to verify the presence of Node.js, Git, and pnpm, and to install Foundry if missing.
- Enhanced user experience by providing clear feedback on dependency status and installation steps.

These changes streamline the setup process for the Cookie Jar protocol, ensuring all necessary dependencies are in place before project execution.
…iseness

- Streamlined the README.md to enhance clarity, focusing on key features and setup instructions.
- Updated client README.md to reflect the new structure and features of the Cookie Jar protocol, emphasizing the React frontend and its functionalities.
- Consolidated technical stack information and improved the organization of sections for better readability.
- Enhanced E2E testing documentation to provide clearer instructions and test structure overview.

These changes improve the overall documentation quality, making it easier for users to understand and navigate the Cookie Jar protocol.
- Renamed workflow from "E2E Tests" to "End-to-End Tests" for clarity.
- Limited push and pull request triggers to the main branch.
- Added a nightly schedule for automated testing.
- Consolidated Node.js and pnpm setup into a single step using a custom action.
- Enhanced the E2E test script to support CI mode with GitHub Actions reporter.
- Improved logging and cleanup processes for background tasks.
- Updated deployment and client startup procedures for better reliability.

These changes streamline the E2E testing process and improve the overall testing framework for the Cookie Jar protocol.
- Removed obsolete dependencies related to Jest and Babel plugins to streamline the lock file.
- Updated package resolutions and integrity checks to reflect the current project requirements.
- Enhanced overall maintainability of the pnpm-lock.yaml file by eliminating unnecessary entries.
@Oba-One
Copy link
Member Author

Oba-One commented Sep 21, 2025

bugbot run

cursor[bot]

This comment was marked as outdated.

- Updated CI workflows to trigger on both main and develop branches for better integration.
- Modified the pnpm install command in the setup action to handle CI environments more gracefully, allowing fallback to regular install if frozen lockfile fails.
- Added informative messages in contract test outputs to guide users on test results.
- Improved NFTGatingEnhanced tests by adding balance checks before withdrawals and ensuring jar balance decreases appropriately after transactions.

These changes enhance the reliability of CI processes and improve the clarity and robustness of NFT-related tests.
- Updated contract test workflow to skip unnecessary Node.js dependencies during contract builds.
- Enhanced output logging for compilation warnings in contract tests, saving logs for review.
- Modified NFTGatingEnhanced tests to ensure proper funding of the jar before withdrawals, improving test reliability.
- Adjusted install-deps.sh to skip Foundry installation in CI environments, streamlining the setup process.

These changes enhance the efficiency of CI processes and improve the robustness of NFT-related tests.
- Updated the code quality workflow to include checks for ESLint configuration and improved logging for linting results.
- Enhanced the unit tests workflow to verify the presence of vitest configuration and added fallback mechanisms for running tests.
- Added a new script for TypeScript type checking in the client package.json.

These changes improve the reliability and clarity of CI processes, ensuring better feedback during code quality checks and testing.
- Updated the code quality workflow to streamline ESLint usage by directly invoking Next.js linting with a non-interactive flag.
- Enhanced the integration tests workflow to check for the existence of the integration test script in package.json and improved fallback mechanisms for running tests.
- Simplified the unit tests workflow by removing unnecessary NODE_OPTIONS and ensuring clearer error messages for test failures.

These changes improve the efficiency and clarity of CI processes, providing better feedback during linting and testing phases.
- Modified the code quality workflow to allow warnings in ESLint but fail on errors, enhancing feedback during linting.
- Updated ESLint rules in the client configuration to turn off console warnings and adjust rules for React and hooks.
- Removed the vitest configuration file as it is no longer needed.
- Enhanced the install-deps.sh script to conditionally skip Foundry installation based on the SKIP_CONTRACTS environment variable.

These changes improve the clarity and efficiency of the CI processes and streamline the linting experience.
@vercel
Copy link

vercel bot commented Sep 21, 2025

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: should NOT have additional property `rootDirectory`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

- Enhanced the code quality workflow to allow builds to continue on formatting issues, improving developer experience during linting.
- Added a new Prettier configuration file and updated the .prettierignore to streamline formatting processes.
- Made minor adjustments to ESLint configuration and ensured consistent formatting across various files.
- Improved test cases and added missing newlines in several components for better code quality.

These changes enhance the CI processes and ensure a more consistent codebase, improving overall maintainability.
- Added `happy-dom` as a testing environment to replace `jsdom`, enhancing compatibility and resolving previous environment issues.
- Updated `vitest` configuration to reflect the new testing environment and improve test execution.
- Included polyfills in the test setup for better Node.js compatibility and addressed compatibility issues with `webidl-conversions` and `whatwg-url`.
- Updated `pnpm-lock.yaml` to include new dependencies and ensure proper versioning.

These changes enhance the testing framework and improve overall test reliability and coverage.
- Added schema reference to `vercel.json` for better validation.
- Standardized quotes in `generated.ts` to single quotes for consistency.
- Removed conflicting optimization settings in `next.config.mjs` to align with Next.js 15's caching mechanisms.

These changes enhance configuration clarity and maintain code consistency across the project.
- Modified the ignoreCommand in vercel.json to simplify the deployment check by removing the specific path to the client directory.

This change enhances the deployment process by streamlining the command used to determine changes.
@Oba-One
Copy link
Member Author

Oba-One commented Sep 21, 2025

bugbot run

cursor[bot]

This comment was marked as outdated.

…logic

- Removed redundant mock implementations and streamlined the EnhancedNFTGateInput component tests for clarity.
- Updated validation logic to ensure accurate detection of NFT types and improved user feedback during input.
- Enhanced test cases to cover various scenarios, including loading states and error handling, ensuring comprehensive coverage of the component's functionality.

These changes improve the maintainability and reliability of the tests for the EnhancedNFTGateInput component.
@Oba-One
Copy link
Member Author

Oba-One commented Sep 21, 2025

bugbot run

cursor[bot]

This comment was marked as outdated.

@Oba-One
Copy link
Member Author

Oba-One commented Sep 21, 2025

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@Oba-One Oba-One merged commit 9f563a7 into dev Sep 21, 2025
7 checks passed
@Oba-One Oba-One deleted the enhancement/e2e-test-infra branch September 21, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants