Audit cookie jar contract for bugs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the CookieJar contract by adding robust NFT access control, including validation of NFT contracts and support for checking ownership of any token within a collection (tokenId 0). It also refactors the CookieJarFactory to dynamically fetch Superfluid host addresses based on the current chain ID, improving network compatibility. Additionally, it introduces a new `SuperfluidConfig` library for managing Superfluid network configurations and updates error handling for ETH transfers in `UniversalSwapAdapter`. Co-authored-by: contact <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix critical ERC721 access validation, ETH transfer method, and withdrawal period logic, and integrate Superfluid with NFT contract validation.
This PR addresses several critical issues identified in a recent audit, including a bug where ERC721
tokenId: 0was incorrectly rejected, inconsistent withdrawal period calculations, and unsafe ETH transfers using.transfer(). It also replaces string reverts with custom errors for gas efficiency and consistency, and introduces robust NFT contract interface validation in the constructor. Finally, it enables Superfluid integration by dynamically fetching host addresses for various chains. Comprehensive tests have been added to cover these fixes and new functionalities.