Release/devconnect #219
Merged
Release/devconnect #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Oba-One
commented
Nov 21, 2025
Oba-One
commented
- Removed direct pinata utility functions and migrated to a new data module for better organization.
- Updated references across the codebase to use the new pinata module structure.
- Enhanced documentation and tests to reflect changes in pinata integration.
- Improved performance by reducing stale time for job queries and work approvals.
- Added new utility functions for transaction polling and translation diagnostics.
Co-authored-by: contact <[email protected]>
- Revised the `AGENTS.md` to provide a clearer reference for AI agents, emphasizing non-negotiable rules and MCP usage. - Removed outdated sections and streamlined content for better readability and accessibility. - Added new documentation files including `Contracts Handbook` and `Platform Overview` to enhance developer resources. - Deleted obsolete files such as `ENVIO_UPDATE_SUMMARY.md`, `DEPLOYMENT.md`, and others to reduce clutter and maintain focus on current practices. - Updated various documentation links to ensure consistency and accuracy across the codebase.
…deployment ownership - Deleted the plans for fixing contract quality issues and deployment ownership as they are no longer relevant. - These plans contained extensive details on E2E tests, deployment strategies, and interface mismatches that have since been addressed or rendered obsolete. - This cleanup helps maintain focus on current development efforts and reduces clutter in the repository.
- Modified `biome.json` to include additional file types for formatting and linting, enhancing support for JSON files across various packages. - Updated `package.json` by removing redundant deployment scripts to simplify the build process. - Adjusted GitHub Actions workflow for admin tests to limit branch triggers, focusing on main and develop branches. - Introduced a new VSCode workspace configuration to improve development experience by organizing project folders and settings. - Deleted obsolete `.vscode/settings.json` and `packages/client/biome.json` to reduce clutter and maintain a cleaner project structure.
- Updated `vite.config.ts` to conditionally set the GraphQL proxy target based on the environment. - Refactored CSS in `index.css` to lock the root document and prevent double scrollbars, improving layout consistency. - Introduced `DashboardLayoutSkeleton` for loading states in `RequireAuth` and `RequireRole` components, enhancing user experience during authentication. - Updated tests in `RequireAuth.test.tsx` and `RequireRole.test.tsx` to reflect changes in authentication logic and loading states. - Added `PageHeader` component for consistent header layout across garden views, improving UI structure and navigation. - Enhanced `CreateAssessmentModal` and `CreateGardenModal` with improved state management and user feedback mechanisms. - Updated `createAssessmentMachine` to enforce validation rules for assessment creation, ensuring data integrity.
- Added `VITE_DEBUG_MODE` environment variable to enable verbose logging for manual testing. - Updated `vite.config.ts` to conditionally set the GraphQL proxy target based on the environment, improving development experience. - Refactored imports in various components to streamline access to shared configurations, enhancing code maintainability. - Introduced new utility functions for debugging, allowing for better error tracking and logging during development. - Enhanced `GardenAssessments` component to include new metrics and evidence handling, improving data presentation. - Updated localization files to include new keys for assessment metrics and evidence, ensuring comprehensive language support. - Refactored `Login` view to improve user experience during authentication, including better error handling and loading states. - Cleaned up obsolete code and comments across multiple files to maintain clarity and focus in the codebase.
- Introduced `VITE_DEBUG_MODE` environment variable to allow for verbose logging and facilitate advancing Garden submissions without media during manual testing. - This addition supports developers in debugging and testing workflows more effectively.
- Removed unnecessary whitespace and formatted the `localhost.json` file for improved readability. - This change enhances the clarity of the configuration while maintaining the existing data structure.
- Introduced a `signOut` function in the `AuthProvider` to handle user logout more effectively, ensuring proper state management and local storage cleanup. - Updated the `ProfileAccount` component to utilize the new `signOut` function for improved logout handling. - Enhanced the `Login` view to manage onboarding state more efficiently, including checks for existing user onboarding status and garden membership. - Refactored the `useAutoJoinRootGarden` hook to streamline garden membership checks and improve user experience during the auto-join process. - Added loading messages during authentication processes to provide better feedback to users.
…e authentication features - Added support for Gardener smart accounts, including the introduction of the `Gardener` contract for user authentication and ENS identity management. - Updated the `ENSRegistrar` to manage subdomain registrations for Gardener accounts on mainnet. - Enhanced the client-side authentication flow with a new recovery route for account recovery via passkeys. - Introduced new hooks and components for managing Gardener profiles, including the ability to update user information and handle ENS claims. - Updated routing to include a recovery path and improved user feedback during authentication processes. - Added integration tests for Gardener account functionalities to ensure reliability and correctness. - Updated dependencies in `package.json` and `bun.lock` to include necessary libraries for the new features. - Refactored existing components to accommodate the new Gardener account logic and improve overall user experience.
…lities - Created a new `shared` package to centralize common utilities, hooks, and components for better code reuse across the monorepo. - Added initial files including configuration, types, and utility functions to support various functionalities. - Established a foundational structure for the shared package, enabling future enhancements and integrations. - Updated relevant imports in existing packages to utilize the new shared utilities where applicable.
- Updated `AGENTS.md` to include prerequisites for Docker and detailed instructions for starting and stopping the indexer. - Modified `config.yaml` to reflect changes in event definitions for the `ENSRegistrar` and removed outdated network configurations. - Introduced a new `setup-and-start.sh` script to streamline the indexer setup process, ensuring Docker is running and managing ReScript dependencies. - Updated `package.json` scripts for improved development experience, including a new `setup-generated` command for ReScript setup. - Removed obsolete ABI files for `ActionRegistry`, `GardenAccount`, `GardenerAccount`, and `GardenToken` to clean up the project structure. - Enhanced `README.md` with clearer instructions for running the indexer and troubleshooting common issues.
…e development setup - Added `@green-goods/shared` package to the workspace for centralized utilities. - Updated `ecosystem.config.js` to swap the `client` and `admin` app configurations for improved development flow. - Modified `package.json` scripts to include a new `build:shared` command and updated linting paths to include the shared package. - Enhanced `playwright.config.ts` to include the admin environment URL for local testing. - Updated VSCode workspace configuration to better organize project folders, including the new shared package structure.
…ture - Removed outdated deployment JSON files for `gardens` across multiple networks to streamline the project structure. - Deleted the `DEPLOYMENT_ARCHITECTURE.md` file as it is no longer relevant. - Added new JSON output files for various contracts to support the latest contract implementations. - Updated the `.gitignore` to ensure sensitive files are excluded from version control. - Introduced new test files for `ENSRegistrar` and `Gardener` to improve test coverage and reliability. - Refactored the `Gardener` contract to enhance functionality and maintainability.
- Replaced `react-hot-toast` with a centralized `toastService` for consistent notification handling across the admin package. - Updated `AddMemberModal` to support ENS name resolution and improved address validation. - Enhanced `CreateAssessmentModal` to provide more informative error messages and success notifications using the new toast service. - Refactored `AddressDisplay` to display ENS names alongside Ethereum addresses for better user experience. - Cleaned up the `Login` component by removing unnecessary console logs to streamline the codebase.
…dling - Introduced a new `toastService` for consistent notification management across the shared package, replacing `react-hot-toast`. - Added `ToastViewport` component for shared styling of toast notifications. - Implemented `useEnsName` and `useEnsAddress` hooks for resolving ENS names and addresses, improving user experience with Ethereum addresses. - Updated various components and hooks to utilize the new toast service for error and success notifications. - Refactored address formatting logic to support ENS names alongside Ethereum addresses. - Enhanced test coverage for new toast functionalities and ENS resolution utilities.
…e and enhance ENS handling - Replaced `react-hot-toast` with the new `toastService` for consistent notification management across the client package. - Updated various components, including `Login`, `Profile`, and `GardenerProfile`, to use the new toast service for success and error notifications. - Enhanced address formatting to support ENS names alongside Ethereum addresses in components like `AddressCopy` and `GardenCard`. - Refactored job queue processing and offline support documentation in `AGENTS.md` to reflect changes in the job queue structure. - Improved user experience by integrating ENS name resolution in components displaying Ethereum addresses. - Added new mock files for testing purposes to support the updated toast service and ENS handling.
…ce integration - Updated `CreateAssessmentModal` to correctly utilize the centralized `toastService` for notifications. - Adjusted TypeScript types in `WorkProvider` to ensure proper handling of asynchronous functions and improve type safety. - Refactored toast options in `ToastViewport` to streamline icon handling and removed redundant success/error/loading configurations. - Enhanced ENS-related types in `ens.ts` for better clarity and usability across the shared package.
- Implemented a centralized theme management system to support dynamic theming across the application. - Updated components to utilize the new `initTheme` function for consistent theme application. - Refactored toast notifications to leverage the `toastService` for improved user feedback and error handling. - Enhanced various components, including `Login`, `Profile`, and `Dashboard`, to ensure they reflect the new theming and notification standards. - Removed deprecated code related to previous theming and notification systems for cleaner codebase.
…guration - Introduced new components for managing actions, including `CreateAction`, `EditAction`, and `ActionDetail`, enhancing the user experience for action submissions. - Added `InstructionsBuilder` and related configuration sections to facilitate dynamic form input management for actions. - Implemented routing for actions, allowing users to navigate between action creation, editing, and detail views. - Integrated a centralized `toastService` for consistent notifications during action operations. - Updated the sidebar navigation to include an "Actions" section for improved accessibility. - Created default action templates to streamline the action creation process. - Enhanced media handling and input validation for action submissions, ensuring a robust user interface.
…unctionality - Introduced a new garden configuration for "Green Goods Open Garden" with detailed attributes including description, location, and associated gardeners and operators. - Implemented the `setOpenJoining` function in the `GardenAccount` contract to allow garden operators to enable or disable open joining. - Created deployment scripts for minting the new garden and updating the root garden reference post-minting. - Enhanced error handling in hooks to provide user-friendly messages for common contract errors. - Refactored existing hooks to utilize the new assessment functionalities and improved error parsing utilities.
- Added `useEnsAvatar` hook for resolving ENS avatars, improving user experience in profile components. - Introduced `ImageWithFallback` component to handle image loading and fallback scenarios, enhancing visual consistency. - Updated various UI components to utilize the new avatar handling, including `Profile`, `GardenerProfile`, and `ImagePreviewDialog`. - Refactored styles across components to improve responsiveness and visual feedback, including tap feedback for buttons and cards. - Enhanced job queue and work submission functionalities with improved error handling and logging for better debugging. - Added new tests for garden filtering and avatar caching to ensure reliability and performance.
Co-authored-by: contact <[email protected]>
…tionality - Upgraded `envio` package from version 2.26.0 to 2.31.1 for improved performance and features. - Added new `useAutoJoinRootGarden` hook to manage automatic joining of the root community garden on user login. - Refactored various components to improve styling and responsiveness, including updates to loading states and skeleton screens. - Enhanced error handling and logging in work submission processes for better user feedback. - Updated tests to cover new functionalities and ensure reliability across components.
- Updated type casting for jobs in the WorkDashboard component to enhance TypeScript type safety. - Ensured proper handling of job data by specifying the Job<WorkJobPayload> type during conversion to Work format.
…e Vite configuration - Removed outdated posthog-js version from client and shared package.json files. - Updated posthog-js to version 1.284.0 in shared package.json. - Added deduplication for React and PostHog in Vite configuration for both client and admin packages to prevent multiple instances. - Optimized dependency pre-bundling for React and PostHog in Vite configuration.
…goods-26cf' of github.com:greenpill-dev-guild/green-goods into patch/release-polish
…itions - Modified tsconfig.json to exclude additional test files for improved build performance. - Refactored useAutoJoinRootGarden hook by removing unused error handling. - Updated WorkDraft and WorkJobPayload interfaces to use Record<string, unknown> for metadata, enhancing type safety. - Improved ENS address resolution logic for better error handling and clarity.
- Removed direct pinata utility functions and migrated to a new data module for better organization. - Updated references across the codebase to use the new pinata module structure. - Enhanced documentation and tests to reflect changes in pinata integration. - Improved performance by reducing stale time for job queries and work approvals. - Added new utility functions for transaction polling and translation diagnostics.
Oba-One
requested review from
Cygnusfear,
MattyCompost,
NFTthat,
cauetomaz,
kitblake,
mrcn and
sofi-verse
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Oba-One
added
api
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+3
to
+4
| export default function RequireOperatorOrDeployer() { | ||
| return <RequireRole allowedRoles={["deployer", "operator", "user"]} />; |
There was a problem hiding this comment.
The new router guard RequireOperatorOrDeployer explicitly whitelists the "user" role (allowedRoles={["deployer", "operator", "user"]}), even though the admin agent guide defines "User" as unauthorized/read-only. With this configuration, any connected wallet that is not an operator or deployer will still pass the guard and gain access to all dashboard routes wrapped by this component (e.g., dashboard, gardens, actions), defeating the role-based access control promised in packages/admin/AGENTS.md and exposing admin tooling to regular users.
Useful? React with 👍 / 👎.
…, and add new documentation - Updated the .env.example file to include the Envio API token. - Modified bun.lock to reflect updated package dependencies. - Added new documentation for gardener accounts architecture. - Cleaned up unused hooks and components in the client package. - Removed obsolete files and tests to streamline the codebase. - Introduced new utility functions and improved existing ones for better performance.
- Modified foundry.toml to adjust fuzzing parameters. - Updated various JSON files in the deployments and output directories to reflect the latest contract changes. - Cleaned up obsolete build-info files to streamline the project structure. - Enhanced deployment scripts for better integration with the updated contract architecture.
….json - Upgraded the envio dependency from version 2.31.1 to 2.32.2 in both bun.lock and package.json files to ensure compatibility with the latest features and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.