Skip to content

fix(client,shared): clarify fund shared fund and endow copy#550

Merged
Oba-One merged 6 commits into
developfrom
afo/prd-518-tracking-clarify-fund-donate-cookie-jar-and-endow-paths
Jun 8, 2026
Merged

fix(client,shared): clarify fund shared fund and endow copy#550
Oba-One merged 6 commits into
developfrom
afo/prd-518-tracking-clarify-fund-donate-cookie-jar-and-endow-paths

Conversation

@Oba-One

@Oba-One Oba-One commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Restores /fund Donate copy to the shared-fund abstraction while preserving the Cookie Jar-backed Donate path.
  • Makes Endow copy explicitly describe the Garden Vault endowment path.
  • Adds regression coverage for /fund rows and funding-card path labels across en/es/pt strings.

Linear: PRD-518

Validation

  • node scripts/dev/ci-local.js --quick
  • bun format
  • bun lint
  • bun run test:client -- src/__tests__/views/fund.test.tsx
  • bun run test:client -- src/__tests__/components/PublicFundingCard.test.tsx src/__tests__/components/PublicFundingDialogVocab.test.ts
  • bun run lint:vocab
  • bun run test:shared -- src/__tests__/i18n/locale-coverage.test.ts
  • bun run build:client
  • Browser DOM/geometry proof against built /fund: Donate and Endow CTAs visible and enabled
  • bun run test full root run blocked by local environment setup: contracts tried to write Foundry submodules under protected linked-worktree git metadata, and indexer pretest hit restricted registry access plus Bun node:sqlite support.

PRD-518 preserves Donate as shared fund support on /fund while making Endow explicitly describe the Garden Vault endowment path.
@Oba-One Oba-One added the automated/codex PR opened by Codex label Jun 8, 2026
@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
green-goods Building Building Preview, Comment Jun 8, 2026 2:27pm
green-goods-admin Building Building Preview, Comment Jun 8, 2026 2:27pm
green-goods-design Building Building Preview, Comment Jun 8, 2026 2:27pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Oba-One, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2b418e7-a994-4809-8397-c070a31af2cf

📥 Commits

Reviewing files that changed from the base of the PR and between 109e919 and c008587.

📒 Files selected for processing (6)
  • docs/docs/builders/packages/client-pwa-token-audit.generated.md
  • packages/admin/src/views/Actions/ActionsSheetDescriptor.stories.tsx
  • packages/client/src/__tests__/views/fund.test.tsx
  • packages/client/src/components/Public/PublicGardenRow.tsx
  • packages/client/src/views/Public/Fund.tsx
  • tests/specs/admin.production-flows.ci.spec.ts
📝 Walkthrough

Walkthrough

This PR adds intent-specific labels and helper text to the public funding UI by distinguishing "Donate" (shared fund support) from "Endow" (Garden Vault endowment) paths. Components render localized labels, views reference updated terminology, and tests verify label presence across both donate and endow flows.

Changes

Donate/Endow Intent Path Labels and Display

Layer / File(s) Summary
i18n strings for donate/endow paths
packages/shared/src/i18n/en.json, packages/shared/src/i18n/es.json, packages/shared/src/i18n/pt.json
Added localized donate/endow path labels (public.fund.card.donatePath, public.fund.card.endowPath), garden helper text (public.fund.gardenDonateHelper, public.fund.gardenEndowHelper), paths disclosure entries with best-for and routes labels, and updated vault lede to reference "Garden Vault endowments" across all three languages.
Component path label and helper text rendering
packages/client/src/components/Public/PublicFundingCard.tsx, packages/client/src/components/Public/PublicGardenRow.tsx
PublicFundingCard computes and renders a localized pathText label under the card title based on donate/endow intent; PublicGardenRow adds localized helper text beneath each Donate/Endow button and wires accessibility via aria-describedby references.
Fund view default copy updates
packages/client/src/views/Public/Fund.tsx
VaultAggregationSection vault lede and SupportPath endow lede updated with new wording that explicitly describes Garden Vault endowment and shared-fund donation routes.
Regression tests for path label display
packages/client/src/__tests__/components/PublicFundingCard.test.tsx, packages/client/src/__tests__/views/fund.test.tsx
PublicFundingCard test verifies correct header labels render for both donate and endow intents; Fund page test verifies each garden row displays both Donate and Endow CTAs with correct intent-specific labels.
Auto-generated token audit update
docs/docs/builders/packages/client-pwa-token-audit.generated.md
Token audit document regenerated with updated line references for PublicFundingCard token usages following component code changes.

🎯 3 (Moderate) | ⏱️ ~20 minutes


🐰 Intent paths now bloom with clarity,
Donate and Endow, distinct and fairly,
Labels guide supporters to choose their way,
Garden flourishes with both routes each day! 🌱💚

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: clarifying fund copy for shared fund donations and endow paths.
Description check ✅ Passed The description clearly relates to the changeset, explaining the restoration of shared-fund copy and explicit endow description with test coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch afo/prd-518-tracking-clarify-fund-donate-cookie-jar-and-endow-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Regenerate the DesignMD client PWA token audit after PRD-518 funding-card line shifts so Design Guardrails passes on PR #550.
@vercel vercel Bot temporarily deployed to Preview – green-goods June 8, 2026 18:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – green-goods-admin June 8, 2026 18:48 Inactive
@vercel vercel Bot temporarily deployed to Preview – green-goods-design June 8, 2026 18:48 Inactive
@Oba-One Oba-One merged commit 02a2da3 into develop Jun 8, 2026
29 checks passed
@Oba-One Oba-One deleted the afo/prd-518-tracking-clarify-fund-donate-cookie-jar-and-endow-paths branch June 8, 2026 19:28
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Green Goods Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated/codex PR opened by Codex

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant