Check timestamp columns (created_at, updated_at) are NOT NULL#186
Merged
gregnavis merged 1 commit intogregnavis:masterfrom Jan 3, 2025
jdufresne:timestamps-not-null
Merged
Check timestamp columns (created_at, updated_at) are NOT NULL#186gregnavis merged 1 commit intogregnavis:masterfrom jdufresne:timestamps-not-null
gregnavis merged 1 commit intogregnavis:masterfrom
jdufresne:timestamps-not-null
Conversation
fatkodima
reviewed
Sep 2, 2024
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
fatkodima
reviewed
Sep 2, 2024
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
gregnavis
requested changes
Sep 3, 2024
Owner
gregnavis
left a comment
gregnavis
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @jdufresne. I appreciate the effort you put into creating a PR.
I left one small comment that will hopefully improve DX.
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
Once the timestamps columns are established on a table, they might as well be NOT NULL to enforce their existence. All ActiveRecord operations set these values so they will always exist under normal usage. Fixes #184
gregnavis
approved these changes
Sep 5, 2024
Owner
gregnavis
left a comment
gregnavis
left a comment
There was a problem hiding this comment.
Thank you for the contribution, @jdufresne.
@fatkodima, could you resolve the outstanding conversations if your concerns were addressed?
Contributor
|
Lgtm 👍 |
gregnavis
force-pushed
the
master
branch
3 times, most recently
from
afcda83 to
4ee897c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the timestamps columns are established on a table, they might as well be NOT NULL to enforce their existence. All ActiveRecord operations set these values so they will always exist under normal usage.
Fixes #184