Skip to content

missing_non_null_constraint: ignore presence validations with specific context #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregnavis merged 1 commit into from
Dec 12, 2024
Merged

missing_non_null_constraint: ignore presence validations with specific context #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/active_record_doctor/detectors/missing_non_null_constraint.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def required_presence_validators(model)
model.validators.select do |validator|
validator.is_a?(ActiveRecord::Validations::PresenceValidator) &&
!validator.options[:allow_nil] &&
validator.options[:on].blank? &&
(rails_belongs_to_presence_validator?(validator) || !conditional_validator?(validator))
end
end
Expand Down
10 changes: 10 additions & 0 deletions test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ def test_validators_allowing_nil_on_optional_columns_are_allowed
refute_problems
end

def test_validators_with_specific_context_on_optional_columns_are_allowed
Context.create_table(:users) do |t|
t.string :name, null: true
end.define_model do
validates :name, presence: true, on: :create
end

refute_problems
end

def test_models_with_non_existent_tables_are_skipped
Context.define_model(:User)

Expand Down