Skip to content

missing_presence_validation: ignore type columns for required polymorphic belongs_to associations#191

Closed
fatkodima wants to merge 1 commit intogregnavis:masterfrom
fatkodima:missing_presence_validation-false-positive
Closed

missing_presence_validation: ignore type columns for required polymorphic belongs_to associations#191
fatkodima wants to merge 1 commit intogregnavis:masterfrom
fatkodima:missing_presence_validation-false-positive

Conversation

@fatkodima
Copy link
Contributor

Currently, if there is a required polymorphic belongs_to association with non null for both columns, missing_presence_validation suggests to add a presence validation for a type column, which is not needed.

@gregnavis gregnavis added the false positive An error is reported when it shouldn't label Dec 12, 2024
@gregnavis gregnavis added this to the 2.0 milestone Jan 4, 2025
@gregnavis
Copy link
Owner

Closing in favor of #230.

@gregnavis gregnavis closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

false positive An error is reported when it shouldn't

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants