missing_non_null_constraint: ignore database views#201
Merged
gregnavis merged 1 commit intogregnavis:masterfrom Jan 11, 2025
Merged
Conversation
Contributor
Author
|
@gregnavis Can you do another round of merges or make me a maintainer of this repository? |
Owner
|
@fatkodima, I'll do some merging soon. Sorry, I've been dealing with some personal stuff. |
gregnavis
requested changes
Jan 11, 2025
Owner
gregnavis
left a comment
gregnavis
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left some comments on the test case.
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
Outdated
Show resolved
Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
Outdated
Show resolved
Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
Outdated
Show resolved
Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
Outdated
Show resolved
Hide resolved
fatkodima
force-pushed
the
missing_non_null_constraint-ignore-views
branch
from
0070422 to
ccb8754
Compare
Contributor
Author
|
Made changes. |
Owner
|
@fatkodima, your nickname should be "lightning" 😄 Thanks for the update. Let's see whether the CI is happy with the new version of |
gregnavis
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.