Skip to content

Fix incorrect_dependent_option checker for broken associations #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregnavis merged 1 commit into from
Jan 3, 2025
Merged

Fix incorrect_dependent_option checker for broken associations #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record_doctor/detectors/incorrect_dependent_option.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def detect
associated_models: [through_association.klass.name],
associated_models_type: "join"
)
next
end
next
end

associated_models, associated_models_type =
Expand Down
19 changes: 19 additions & 0 deletions test/active_record_doctor/detectors/incorrect_dependent_option_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,25 @@ def test_has_through_associations_when_join_model_incomplete
OUTPUT
end

def test_has_through_associations_with_bad_source
Context.create_table(:users).define_model do
has_many :posts
has_many :comments, through: :posts, source: :non_existent
end

Context.create_table(:posts) do |t|
t.references :users
end.define_model do
has_many :comments
end

Context.create_table(:comments) do |t|
t.references :posts
end.define_model

refute_problems
end

def test_destroy_async_and_foreign_key_exists
Context.create_table(:companies) do
end.define_model do
Expand Down