Start revising cli tests #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to check for gregorio version? Or is it good enough to change: to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a sample of how I'm thinking of revising the scripted cli tests. The basic idea is to capture the expected output (either to stdout or stderr or both) and make sure it's correct. Right now I've not expanded the number of tests, but I could see testing the stdout output and the stderr output in separate tests (e.g. stdin_and_stdin.sh would become 2 tests).
Some form of VersionManager.py (from the main repository) will probably need to be added to the repository for this to work (as version number appears in some output, e.g. version.sh).
What do people think about this revision?