Skip to content

Yuxincs/fix fact exporting#1

Open
lizard-boy wants to merge 4 commits into
mainfrom
yuxincs/fix-fact-exporting
Open

Yuxincs/fix fact exporting#1
lizard-boy wants to merge 4 commits into
mainfrom
yuxincs/fix-fact-exporting

Conversation

@lizard-boy

Copy link
Copy Markdown

No description provided.

yuxincs added 4 commits May 2, 2024 15:23
This reverts commit 20e634f9387a5c95031199dd08061b9031ee3851.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements fact exporting fixes and upgrades Bazel configuration across the repository. New BUILD and MODULE files clarify dependency management, while analyzer and inference packages update logging and error handling.

• Added MODULE.bazel and multiple BUILD.bazel files (e.g., /accumulation/BUILD.bazel, /annotation/BUILD.bazel) to configure Bazel builds.
• Updated accumulation/analyzer.go and inference/inferred_map.go with new logging calls that use WriteLog but should be refactored to use the custom logging module (logger.error(...)).
• nilaway.go now comments out deferred error reporting, which may suppress important diagnostics.
• Overall dependency and build configurations align with fact exporting improvements.

27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants