Rollout passChildrenWhenCloningPersistedNodes flag#129
Closed
everettbu wants to merge 1 commit into
Closed
Conversation
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#34238
Original author: javache
Summary
passChildrenWhenCloningPersistedNodes was evaluated internally at Meta and all known regressions have been resolved. This is a valuable performance improvement for React Native performance and it should be rolled out everywhere.
This change does not have user-visible behaviour, it just affects how Fabric keeps track of the ShadowTree internally.
How did you test this change?
Unit tests updated