[compiler] Improve hook validation diagnostics

[everettbu]

Mirror of facebook/react#34246
Original author: josephsavona

---

---

Stack created with Sapling. Best reviewed with ReviewStack.

• -> #34246
• #34176

[greptile-apps]

Greptile Overview

Greptile Summary

Refactored compiler diagnostic system to improve hook validation error messages and consistency across the codebase.

Key changes:

• Introduced structured reason and description fields to CompilerDiagnostic, separating concise error summaries from detailed explanations
• Migrated category field from free-form strings to typed ErrorCategory enum for consistency
• Updated ValidateHooksUsage.ts to use new diagnostic structure with clearer, more actionable error messages
• Added getRuleForCategory() mapping function to associate error categories with ESLint rule metadata
• Updated 100+ test fixtures to reflect improved error message formatting
• Refactored ESLint plugin to extract shared compiler execution logic into RunReactCompiler module
• Removed duplicate React Compiler rule from eslint-plugin-react-hooks package

Confidence Score: 5/5

• This PR is safe to merge - it's a well-structured refactoring that improves diagnostic quality without changing validation logic.
• This is a comprehensive but clean refactoring focused on improving the diagnostic/error reporting infrastructure. The changes are systematic (migrating from CompilerErrorDetail to CompilerDiagnostic, adding reason field, enum-ifying category), extensively tested (141 test fixture updates), and don't alter the underlying validation logic. The separation of concerns between reason and description improves error message clarity.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateHooksUsage.ts	5/5	Refactored error reporting from CompilerErrorDetail to CompilerDiagnostic with structured reason/description separation. Improved error messages with clearer summaries.
compiler/packages/babel-plugin-react-compiler/src/CompilerError.ts	5/5	Major refactoring: added reason field to diagnostics, changed category from string to ErrorCategory enum, and added getRuleForCategory() mapping function.
compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts	5/5	Updated all error creation sites to add category field and reason field, migrating from strings to ErrorCategory enum values.
compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts	5/5	Refactored to extract React compiler execution logic into shared RunReactCompiler module, reducing code duplication.

[greptile-apps]

_{139 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}