Run all tests with devtools attached#137
Draft
everettbu wants to merge 5 commits into
Draft
Conversation
will probably remove later. The main goal here is to establish smoke tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#34466
Original author: eps1lon
Stacked on react/react#34464
We'll probably need to start with an allow-list first because some tests are not compatible (specifically ones testing RDT integration).
Maybe this will just be an extra config if it's too slow. Ideally we take a store snapshot after each
act. Not sure yet how that'll look to not be too disruptive.Need to go through some of the instrumentation failures this is currently reporting. The ones related to
react-test-rendererI'm not too worried. That renderer is deprecated anyway.