[DevTools] Update ReadMe Docs For WebExtensions#138
Conversation
Greptile OverviewGreptile SummaryThis PR attempts to fix outdated documentation that references a non-existent
Confidence Score: 1/5
Important Files ChangedFile Analysis
|
| @@ -1,6 +1,6 @@ | |||
| # The Chrome extension | |||
|
|
|||
| The source code for this extension has moved to `shells/webextension`. | |||
| The source code for this extension has moved to ~~`shells/webextension`~~. | |||
There was a problem hiding this comment.
logic: Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
| The source code for this extension has moved to ~~`shells/webextension`~~. | |
| The source code for this extension is in `../src`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-devtools-extensions/chrome/README.md
Line: 3:3
Comment:
**logic:** Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
```suggestion
The source code for this extension is in `../src`.
```
How can I resolve this? If you propose a fix, please make it concise.| @@ -1,6 +1,6 @@ | |||
| # The Microsoft Edge extension | |||
|
|
|||
| The source code for this extension has moved to `shells/webextension`. | |||
| The source code for this extension has moved to ~~`shells/webextension`~~. | |||
There was a problem hiding this comment.
logic: Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
| The source code for this extension has moved to ~~`shells/webextension`~~. | |
| The source code for this extension is in `../src`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-devtools-extensions/edge/README.md
Line: 3:3
Comment:
**logic:** Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
```suggestion
The source code for this extension is in `../src`.
```
How can I resolve this? If you propose a fix, please make it concise.| @@ -1,6 +1,6 @@ | |||
| # The Firefox extension | |||
|
|
|||
| The source code for this extension has moved to `shells/webextension`. | |||
| The source code for this extension has moved to ~~`shells/webextension`~~. | |||
There was a problem hiding this comment.
logic: Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
| The source code for this extension has moved to ~~`shells/webextension`~~. | |
| The source code for this extension is in `../src`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-devtools-extensions/firefox/README.md
Line: 3:3
Comment:
**logic:** Incomplete documentation fix - the sentence now says "has moved to" but provides no destination. Should replace with the correct path.
```suggestion
The source code for this extension is in `../src`.
```
How can I resolve this? If you propose a fix, please make it concise.|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Mirror of facebook/react#34496
Original author: ospira
Summary
All three browser extension ReadMe files reference a path (
shells/webextension) for common source code that I believe no longer exists.I have a guess where the correct path now is, but given it should be easy for the maintainers to make this correction themselves (accurately and without guessing), I'm simply flagging it.
Thus for this PR to be completed it would need to replace the struck out characters with an updated, correct path. If I have made a mistake I apologize, but as you can see in that screenshot I could not find
shells/webextension... I was able to find a top-levelshellsdirectory in the git history, but I must admit the git history is a little confusing, perhaps because this code used to live in a separate repo once upon a time?In any event, it would be great if one of the maintainers could spend a few minutes confirm the issue and give a quick update for people coming to this fresh who want to dive into this particular aspect of the source code. Thanks for your time!
How did you test this change?
N/A