Skip to content

fix: replace en-dash with hyphen in fixture filenames (#34489)#140

Closed
everettbu wants to merge 1 commit into
mainfrom
main-34529
Closed

fix: replace en-dash with hyphen in fixture filenames (#34489)#140
everettbu wants to merge 1 commit into
mainfrom
main-34529

Conversation

@everettbu

@everettbu everettbu commented Dec 12, 2025

Copy link
Copy Markdown

Mirror of facebook/react#34529
Original author: VaishnaviShirishBorkar


I renamed two test fixture files to replace en-dashes with hyphens and updated references. Tests pass in CI on the React side. Closes #34489

@greptile-apps

greptile-apps Bot commented Dec 12, 2025

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

Renamed two test fixture files to replace en-dashes (–) with hyphens (-) for better compatibility and consistency.

  • File rename: functionexpr–conditional-access.expect.mdfunctionexpr-conditional-access.expect.md
  • File rename: functionexpr–conditional-access.jsfunctionexpr-conditional-access.js
  • No content changes in either file
  • Test discovery is handled dynamically via glob patterns in compiler/packages/snap/src/fixture-utils.ts, so the rename will be automatically picked up without requiring code changes

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • Perfect score given because this is a pure file rename with no content changes, no references to update, and the test framework automatically discovers fixtures by glob patterns
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
compiler/packages/babel-plugin-react-compiler/src/tests/fixtures/compiler/functionexpr-conditional-access.expect.md 5/5 Renamed from en-dash to hyphen in filename - no content changes
compiler/packages/babel-plugin-react-compiler/src/tests/fixtures/compiler/functionexpr-conditional-access.js 5/5 Renamed from en-dash to hyphen in filename - no content changes

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@everettbu everettbu added the Resolution: Stale Automatically closed due to inactivity label Dec 18, 2025
@github-actions

Copy link
Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions Bot closed this Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Resolution: Stale Automatically closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants