[Compiler] Don't throw calculate in render when there is a global function call in the effect

[everettbu]

Mirror of facebook/react#34578
Original author: jorge-cab

---

Summary:
Global function calls can introduce unexpected side effects, for this first iteration we are bailing out the validation when we encounter one.

Local function calls remain

---

Stack created with Sapling. Best reviewed with ReviewStack.

• #34580
• #34579
• -> #34578
• #34577
• #34575
• #34574

[greptile-apps]

Greptile Overview

Greptile Summary

Implements conservative bailout logic for the experimental effect validation by skipping validation when global or prop function calls are detected within effects.

Key Changes:

• Adds globals tracking in validateEffect to identify LoadGlobal instructions
• Returns early (bails out) when a global function is called within an effect (lines 398-401)
• Returns early when a prop function is called within an effect (lines 389-396)
• Local function calls continue to trigger the validation error as intended
• Adds comprehensive test coverage for global, prop, and local function call scenarios

Rationale:
Global and prop function calls may have side effects that are difficult to analyze statically. The conservative approach avoids false positives by not flagging these patterns, while still catching clear anti-patterns with local functions and direct derivations.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes implement a well-reasoned conservative approach to avoid false positives. The validation logic correctly identifies globals via LoadGlobal instructions and bails out appropriately. Test coverage is comprehensive with both positive (no-error) and negative (error) cases.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoDerivedComputationsInEffects_exp.ts	5/5	New experimental validation that detects derived state computations in effects, with bailout logic for global and prop function calls
compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts	5/5	Adds conditional execution of experimental validation based on config flag
compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts	5/5	Adds new config option validateNoDerivedComputationsInEffects_exp with default false
compiler/packages/babel-plugin-react-compiler/src/tests/fixtures/compiler/effect-derived-computations/effect-with-global-function-call-no-error.js	5/5	Test case verifying no error when effect contains global function call alongside setState
compiler/packages/babel-plugin-react-compiler/src/tests/fixtures/compiler/effect-derived-computations/error.effect-contains-local-function-call.js	5/5	Test case verifying error is still thrown when effect contains local function call

[greptile-apps]

_{35 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[everettbu]

Upstream PR was closed or merged. Code is synced via branch mirror.