Skip to content

fix(compiler): compiler workspaces setting#160

Closed
everettbu wants to merge 1 commit into
mainfrom
fix/add-apps-to-workspaces
Closed

fix(compiler): compiler workspaces setting#160
everettbu wants to merge 1 commit into
mainfrom
fix/add-apps-to-workspaces

Conversation

@everettbu

@everettbu everettbu commented Dec 12, 2025

Copy link
Copy Markdown

Mirror of facebook/react#34799
Original author: arthur-mountain


Summary

The 'start' and 'next' scripts in the compiler monorepo reference 'yarn workspace playground', but the playground app in compiler/apps/playground was not included in the workspaces configuration. This caused these commands to fail.
Screenshot 2025-10-10 at 6 17 28 PM

This PR adds 'apps/*' to the workspaces.packages array to properly register the playground workspace.

How did you test this change?

Verified by running 'yarn start' locally, and confirmed that the snapshot error shown above no longer appears.

The 'start' and 'next' scripts reference 'yarn workspace playground'
but the playground app in apps/playground was not included in the
workspaces configuration. This caused these commands to fail.

Added 'apps/*' to the workspaces.packages array to properly register
the playground workspace.
@greptile-apps

greptile-apps Bot commented Dec 12, 2025

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

Added apps/* to the workspaces configuration to properly register the playground app. This fixes the yarn start and yarn next commands which reference yarn workspace playground but were failing because the playground app in compiler/apps/playground wasn't included in the workspaces.

  • Verified that compiler/apps/playground/package.json exists with name "playground"
  • The scripts in compiler/package.json (lines 16-17) reference yarn workspace playground, confirming the need for this change
  • Only one app currently exists in the apps directory (playground), making this a straightforward fix

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, well-justified configuration fix that adds the missing apps/* workspace pattern. The playground app exists and is referenced by existing scripts, so this change simply corrects an oversight in the workspace configuration. No logic changes or potential side effects.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
compiler/package.json 5/5 Added apps/* to workspaces to register playground app

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@everettbu everettbu added the Resolution: Stale Automatically closed due to inactivity label Jan 22, 2026
@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Jan 27, 2026
@everettbu
everettbu deleted the fix/add-apps-to-workspaces branch January 27, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Resolution: Stale Automatically closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants