DevTools: Fix nested HOC name extraction in extractHOCNames#267
Closed
everettbu wants to merge 1 commit into
Closed
DevTools: Fix nested HOC name extraction in extractHOCNames#267everettbu wants to merge 1 commit into
everettbu wants to merge 1 commit into
Conversation
extractHOCNames unwraps displayName strings like: withFoo(withBar(Component)) The previous implementation used a global RegExp and relied on RegExp.exec() while mutating the input string. Because global RegExp instances keep state via lastIndex, nested wrappers could stop unwrapping early and only record the outermost wrapper. Use an anchored, non-global RegExp so each unwrap re-parses the updated name from the beginning, avoiding lastIndex drift. Add unit tests covering nested wrappers, a single wrapper, and no-wrapper cases. Test Plan: node ./scripts/jest/jest-cli.js --project devtools --build \ --runTestsByPath packages/react-devtools-shared/src/__tests__/extractHOCNames-test.js
Greptile SummaryFixed a subtle RegExp bug in
Confidence Score: 5/5
Important Files Changed
|
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35398
Original author: TerryTaoYY
Problem
extractHOCNamesis responsible for unwrapping displayName strings such as: withFoo(withBar(Component))The previous implementation used a global RegExp and iterated via RegExp.exec() while mutating the input string on each unwrap. Because global RegExp instances carry state via
lastIndex, nested wrappers could stop unwrapping early and only record the outermost HOC.Solution
Switch to an anchored, non-global RegExp so each unwrap re-parses the updated string from the beginning, eliminating
lastIndexdrift across iterations.Tests
Test Plan
node ./scripts/jest/jest-cli.js --project devtools --build
--runTestsByPath packages/react-devtools-shared/src/tests/extractHOCNames-test.js